Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Bundle more icons with good names #2282

Open
16 tasks
kfarmer-msft opened this issue Aug 6, 2019 · 4 comments
Open
16 tasks

Feature Request: Bundle more icons with good names #2282

kfarmer-msft opened this issue Aug 6, 2019 · 4 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone

Comments

@kfarmer-msft
Copy link

kfarmer-msft commented Aug 6, 2019

Description of the new feature/enhancement

There are a number of interesting icons that could apply in various situations, such as the VS icon, the Azure or Office/Exchange logos, SQL, GitHub, etc as well as various generic icons like a database drum or a terminal icon.

Proposed technical implementation details (optional)

Adding new icon assets and giving them a good name should be easy for Microsoft-owned properties. Some may need to be invented (eg, C# has no logo, where F# has a rather spiff one).

Care should be taken to include variants for various contrast situations.

Giving them real names instead of GUID names would make them easier to use without having to track down random images on the web, or something buried in the file system.

Proposed icon set:

  • Visual Studio
  • C# (needs to be defined)
  • F#
  • Exchange
  • GitHub
  • Azure
  • Microsoft
  • Windows (CMD's icon is.. not great)
  • Generic network terminal (eg, for SSH, Telnet, FTP, etc)
  • Generic database
  • Generic file system

Potential third party icons, if they agree?

  • Git
  • Python
  • Julia
  • Wolfram
  • Create mechanism to propose new ones to engage
@kfarmer-msft kfarmer-msft added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 6, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 6, 2019
@kfarmer-msft
Copy link
Author

Idle thought -- Some of the generic set could no doubt be found in common fonts. XAML allows buttons to be defined using symbol fonts -- perhaps that can be an alternative mechanism for defining icons? It also would allow, then, for defining font color. Worth a separate feature proposal, perhaps?

@DHowett-MSFT
Copy link
Contributor

I'd like to do this in the future, but I'm wary of adding what is effectively an API (user settings take dependency on these things, we can't change them lightly). In my head it's blocked behind #1564 because that would give users a good way to discover those icons and set them as profile values and drag/drop in their own icons and all that jazz.

@DHowett-MSFT DHowett-MSFT added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 16, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 16, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone Aug 16, 2019
@cloudhan
Copy link
Member

Maybe support base64 encoded image?

@cloudhan
Copy link
Member

cloudhan commented Sep 25, 2019

e.g.
{b453ae62-4e3d-5e58-b989-0a998ec441b8} scale-200
is simply a line in config

data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAABHNCSVQICAgIfAhkiAAAAAlwSFlzAAAELgAABC4BL4L3AQAAABl0RVh0U29mdHdhcmUAd3d3Lmlua3NjYXBlLm9yZ5vuPBoAAAMsSURBVFiF7ZXNbxtVFMV/b2Zsxx+J7YQQ3DaJWKGmVQRqaYkgmy5YIFQhWJQNQrBAgrb8BUhdRMomXVSQDXsKbFhBEVL/AJDcCooEiJRKAackJa5npmN7xvP1WNCmTqadiel0gehZzX3vnneO7n13HjzC/x1iaWlpLpfLPZXWga1Wy/E8L5BSGouLixcTDSwvL7eFEMU0xDudDoZhbMWqqh5cWFj4KY6jpCVu2zamaW5b831/JImnpCHuOA66riOlHJirTU5OWQ8i7vk+pmkGlepoZC8MSHSkCUUZXukMsebkBhZ3vYA/9Q5BOL5tvZLxOTZmoqlSJBoAuNoeom6WBhLv+ZJfN228IBPZm873ODZm3oMVxdYdqI1keX++xt5yNpHkBZKVTRsvGLznO6Hd+Vi/5fL1Lzonnn6MSl7l8++b/HzDjhD8EFY2HdwUxGHHFHS9kK4XoAhBRo0OSCDhatPG8cNUxKGvArWRLG8cGueLH2/yW9MB4KX9VWYm8gA0DJeFi2t03WTxjKqQGSqgaZmhpFzx5VcX5IUbldhLKIFrTQfTCWIPOzpV4s0j4zyzt4iqiNtUeRmUc8/uK34qhIj0bVc/otVWL1H83eef4MNXn+TwZOmOOIAAcRjkJ/Xr7c8uXZKRkUk08Ifh0ur6sTmvzY7y1pFxRNzUS06EE+2zAxm4brpstr2tOKMIZiYKzO4pUMj+Qy1kFU7O12IN9uHkt6vW/v4F7X6Zf7U9Nqy74scPVDk9X6OcVwHo+SHnLzdZbfUoZXf9pKiqyuvAmVgDN7s+DcPdil+eqfDBi/u25eQ0hbePPo5hx9+Ne+BgfxCxbtgBv+u9u5YVwemYElduV2QAHK83rCv1hnVKSik0gHLGZ0/Oxer5tGyb6b7pnRrNUy3ct1P/BpqEWeCjeqOT04RAf2G0XX1uWOeWZSHHto9qrjjCjqqlByHf0wr58pyqBtPr6+u6DIPIb87tdVQp5TdCiOpDsFBOfK8B6mvWO1Ly8UMwcH5XBgDqDeuUhEVgOCXx70JPvLJrAwBXNjaKblCaC6V8oHaoinLtUK3wgxAivWf1Ef6z+BshUTGjcwAQnAAAAABJRU5ErkJggg==

@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants