Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor shape: Filled box does not work as expected. #15033

Closed
kgfly opened this issue Mar 22, 2023 · 8 comments
Closed

Cursor shape: Filled box does not work as expected. #15033

kgfly opened this issue Mar 22, 2023 · 8 comments
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@kgfly
Copy link

kgfly commented Mar 22, 2023

Windows Terminal version

1.16.10262.0

Windows build number

10.0.22621.1413

Other Software

No response

Steps to reproduce

Change cursor shape to Filled box
type aaa
and move back one character.

Expected Behavior

Windows classic console
image

You can see "a" easily, under the cursor. The black font is easy to see.

Linux has similar behavior.

Actual Behavior

image

It's hard to see "a" under the cursor. The gray font is hard to see.

@kgfly kgfly added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 22, 2023
@lhecker
Copy link
Member

lhecker commented Mar 23, 2023

As a workaround, until we fix the default text renderer, you can opt into the upcoming text renderer here:
image

After clicking save, you have to close and reopen all your tabs.

@lhecker lhecker added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Product-Terminal The new Windows Terminal. labels Mar 23, 2023
@kgfly
Copy link
Author

kgfly commented Mar 23, 2023

Thanks.

Is there an active tracking item for "until we fix the default text renderer, "?

@YUSHACOD
Copy link

The thing with the current work-around is that it will work for certain color schemes but not so well for others. This is very annoying as the cursor is the most important part of the terminal app. And working without being able to see the text is an horrible nightmare.

@lhecker
Copy link
Member

lhecker commented Mar 24, 2023

If you don't mind, could you give me an example for a color theme with which the workaround doesn't work? I'd be interested in fixing any such issues.


Is there an active tracking item for "until we fix the default text renderer, "?

Edit: No there isn't. Let's use this one. 🙂

@lhecker
Copy link
Member

lhecker commented Mar 24, 2023

Oh, I think I can already guess what the issue is. Some themes use colored cursors and if the theme specifies colored cursors, we do draw them in that exact color. This affects all 3 built-in light themes.
Right now, it's a bit of a hidden trick, but to get inverted cursors in AtlasEngine you have to make sure the cursor color is set to #FFFFFF. I think once we roll that new text renderer out as the default, there's a high chance we'll modify all built-in themes to use such inverted cursors instead of colored ones.

@YUSHACOD
Copy link

Oh, I can't thank you enough. It works perfectly now. Just setting the cursorColor did the trick.

@zadjii-msft
Copy link
Member

I'm gonna call this a /dupe of #9610, yea? basically, there is an undocumented way to get cursor inverting, but we still need to spec up the right way to definitely support it.

@microsoft-github-policy-service
Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants