Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot start after updating to 1.16 - likely due to elevate:true #14729

Closed
z4668640 opened this issue Jan 25, 2023 · 8 comments
Closed

Cannot start after updating to 1.16 - likely due to elevate:true #14729

z4668640 opened this issue Jan 25, 2023 · 8 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Severity-Crash Crashes are real bad news.

Comments

@z4668640
Copy link

Windows Terminal version

1.16.10232.0

Windows build number

windows 11 OS: 25281.1000

Other Software

No response

Steps to reproduce

Double clicking on the icon does nothing. Nothing is displayed.

Expected Behavior

No response

Actual Behavior

Couldn't launch today after Microsoft Store updated with the latest version. Double clicking on the icon does nothing. Nothing is displayed.

@z4668640 z4668640 added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 25, 2023
@Robo210
Copy link
Contributor

Robo210 commented Jan 25, 2023

I have yet to debug what is going on, but on my machine something similar started happening as soon as I got the update to 1.16, except that after 10 minutes or more the window suddenly appears. I can see the process is running the whole time in Task Manager.

Hitting "Save" in the settings also triggers a 10+ minute hang.

@zadjii-msft
Copy link
Member

quick sanity check: are you using elevate:true/?

Hitting "Save" in the settings also triggers a 10+ minute hang.

This seems like a different issue. Actually, @Robo210 your whole post sounds like a different issue - mind filing a new thread? I just want to make sure we track all these regressions to their individual root causes, and not conflate them.

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 25, 2023
@educatedpork
Copy link

I'm also encountering this problem - as soon as I installed 1.16.10232.0 (Windows 11) attempts to launch Terminal failed in the way described.

quick sanity check: are you using elevate:true/?

I am using 'elevate:true' here - and editing my settings.json to remove that results in me being able to launch Terminal again. But unfortunately without Administrator privilege, which isn't great. As soon as I re-enable "Run this process as Administrator" again, save, and re-launch - well.. it doesn't launch again.

Dean

@z4668640
Copy link
Author

I think the above reply is correct. It starts when I change "elevate": true to "elevate": false. When I go back to "elevate": true, it doesn't start. At present, you can only manually find settings.json file to modify it.

@z4668640 z4668640 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2023
@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jan 25, 2023
@zadjii-msft
Copy link
Member

zadjii-msft commented Jan 25, 2023

Okay well that's some sane confirmation, even if it's mysterious and confusing.

For the record, if you really need elevate:true, we think 1.17 Preview should work for you. Based on the reports here, this sounds like #14501 which seems to be fixed by #14637.

I still don't understand how this regressed in 1.16 in the first place... The list of https://github.com/microsoft/terminal/commits/release-1.16 doesn't have anything I'd immediately peg as dangerous. #14123 is maybe the spiciest title, but that seems... mundane.

I guess the original issue repro'd in 1.15.2875.0, which seems to imply that this would have regressed in a 1.15 version. But that doesn't really make sense - then we would have gotten way more reports about this before the 1.15->1.16 release.

I TAKE THAT BACK, #14520 is in 1.16 release. That's sus for sure.

It might be valuable to know what Windows builds folks are on. I suspect this only impacts Windows 11 users. Knowing the exact build numbers might help us ID if it's an OS regression, or something due to the win10/win11 package split

@zadjii-msft zadjii-msft added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Jan 25, 2023
@zadjii-msft zadjii-msft changed the title Cannot start after updating the latest version Cannot start after updating to 1.16 - likely due to elevate:true Jan 25, 2023
@zadjii-msft zadjii-msft pinned this issue Jan 25, 2023
@educatedpork
Copy link

It might be valuable to know what Windows builds folks are on.

Sure, I'm seeing this on Windows 11 21H2 (22000.1455). I can also confirm that I'm not seeing any (obvious) problems with elevation using the latest 1.17 preview build.

Dean

@DHowett DHowett reopened this Jan 26, 2023
@DHowett DHowett added Severity-Crash Crashes are real bad news. and removed Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Needs-Attention The core contributors need to come back around and look at this ASAP. labels Jan 26, 2023
@z4668640
Copy link
Author

I noticed that the program has been updated to version 1.16.10262.0. The log shows that the problem is fixed, and the program can run normally after my test. I think it's time to close this issue. What do you think?

@DHowett
Copy link
Member

DHowett commented Jan 28, 2023

Ah, you're totally right. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Severity-Crash Crashes are real bad news.
Projects
None yet
Development

No branches or pull requests

5 participants