Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon of console application doesn't get used #14372

Open
Tracked by #13392
gyorokpeter opened this issue Nov 11, 2022 · 3 comments
Open
Tracked by #13392

Icon of console application doesn't get used #14372

gyorokpeter opened this issue Nov 11, 2022 · 3 comments
Labels
Area-DefApp Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.

Comments

@gyorokpeter
Copy link

Windows Terminal version

1.15.2875.0

Windows build number

10.0.22621.819

Other Software

FAR Manager or any console app with an embedded icon

Steps to reproduce

Launch a console application that has an embedded icon in its executable, such as FAR Manager. The Windows update that causes every console application to launch in Windows Terminal (instead of the old console app) must be installed.

Expected Behavior

The embedded icon in the executable should be used as the tab icon inside Windows Terminal.
The embedded icon in the executable should be used as the taskbar icon.

Actual Behavior

The tab icon remains the default generic icon (which looks like C:\ on a white background).
The taskbar icon remains the default generic icon (which looks like >_ on a black background).

This makes it difficult to distinguish between different console applications.

@gyorokpeter gyorokpeter added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 11, 2022
@zadjii-msft
Copy link
Member

Do we really not have a specific thread tracking this? This sits somewhere between #9458, #1504, #12154, and is broadly tracked in #13392, but we may have not actually dedicated a specific thread just to the icon during handoff.

I guess this is that thread now!

@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-DefApp and removed Issue-Bug It either shouldn't be doing this or needs an investigation. labels Nov 11, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.17 milestone Nov 11, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 11, 2022
@DHowett
Copy link
Member

DHowett commented Nov 11, 2022

Good catch on us not having an issue for this... probably just a bullet point in some other place we never formally tracked. Thanks for filing it, @gyorokpeter!

@zadjii-msft
Copy link
Member

zadjii-msft commented Nov 14, 2022

Oh wait, this might actually be tracked in #7552

EDIT; it is not. This is about defterm, that other thread is not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-DefApp Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
Status: Should be written
Development

No branches or pull requests

4 participants