Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"cmd.exe" does not exit the terminal properly if the last command didn't exit with 0 #13814

Closed
dovholuknf opened this issue Aug 22, 2022 · 6 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@dovholuknf
Copy link

Windows Terminal version

1.14.1963.0

Windows build number

No response

Other Software

cme.exe - whatever comes with windows 11 latest

Steps to reproduce

  • set windows terminal preview as the default terminal application and save that setting
  • hit the start key
  • type: cmd.exe [enter] (to open "Command Prompt - App")
  • type: type bob
  • i expect you'll see: "The system cannot find the file specified."
  • type: exit

Expected Behavior

the terminal should exit

Actual Behavior

the terminal stays alive indicating:

C:\Users\user_name>exit

[process exited with code 1 (0x00000001)]
@dovholuknf dovholuknf added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Aug 22, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 22, 2022
@DHowett
Copy link
Member

DHowett commented Aug 22, 2022

Thanks for the report! This has been fixed as of 1.15 builds 200x+. /dup #13325.

@ghost
Copy link

ghost commented Aug 22, 2022

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Aug 22, 2022
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 22, 2022
@dovholuknf
Copy link
Author

image

the steps to report a bug are incorrect if you're using the terminal preview. turns out i am running 1.15.2003.0 and the bug is most definitely still present

@dovholuknf
Copy link
Author

@DHowett - would you mind reopening/retriaging this bug? or i can just file another if i have to?

@zadjii-msft
Copy link
Member

Sorry, more correctly, this is fixed in Preview v1.15.228, which should also be appearing by default on some set of stable builds also, but those haven't been spun up quite yet.

It's enabled by a small change to the closeOnExit setting, which might have already been persisted as graceful in your settings. After #13560 is released, the new default should be automatic, which will do what you want. Till then, you can use closeOnExit: always

@dovholuknf
Copy link
Author

Good grief - I had found/used closeOnExit": "always" for other profiles but didn't apply it to 'defaults"... Which i just rectified, thanks!

        "defaults": 
        {
            "closeOnExit": "always",
            ...
            ...

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants