Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"startupActions": with quake mode are not behaving correctly #12858

Closed
mullcom opened this issue Apr 8, 2022 · 3 comments
Closed

"startupActions": with quake mode are not behaving correctly #12858

mullcom opened this issue Apr 8, 2022 · 3 comments
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Answered Related to questions that have been answered

Comments

@mullcom
Copy link

mullcom commented Apr 8, 2022

Windows Terminal version

1.13.10733.0

Windows build number

10.0.19044.1586]

Other Software

No response

Steps to reproduce

Run command in a sinel terminal
wt -w _quake ;sp -H;sp;sp

Then test add this now to settings json file
"startupActions": "wt -w _quake sp -H;sp;sp",

Expected Behavior

All sp i add in startupActions wt command should release on quake mode window.

Actual Behavior

i have try to get several sp in but only manage get one sp in quake mode the rest adds to startup terminal.

@mullcom mullcom added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Apr 8, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 8, 2022
@zadjii-msft
Copy link
Member

I don't think wt -w is supported in startupActions at all... Hmm.

@mullcom
Copy link
Author

mullcom commented Apr 8, 2022

it working with two SP so but failing when i add more. yast test it for your self and you find out.

zadjii-msft commented on Jul 26, 2021
At the moment, not really.

You could do something like wt -w _quake -p {your profile name} - that'll launch the Terminal into quake mode with the profile of your choice.
You could always rebind quakeMode to a generic globalSummon action. That'd let you just summon any Terminal window, not just the quake one.
Otherwise, you could wait for #9992 to be able to change the defaultProfile of the _quake window separately from the normal default

@zadjii-msft
Copy link
Member

Okay I see what's going on here.

When you put wt -w _quake sp ; sp ; sp into startup actions, here's what happens:

  • the terminal parses this into three subcommands: [wt -w _quake sp, sp, sp]
  • The first one doesn't parse as an action. wt isnt a subcommand, so we treat it as a commandline. We run a tab with the commandline wt -w _quake sp.
    • THIS CREATES A NEW WINDOW, the quake window, with a commandline of sp
    • The quake window defaults to creating a tab. Then it processes the sp, splitting the pane.
  • The original terminal window then parses a sp, and creates a new split for this sp.
  • The original terminal window then parses a sp, and creates a new split for this sp.

So, you end up with two terminal windows, a _quake window and a normal one, each with two panes.

Putting -w in the startupActions is definitely not recommended. What I was talking about above was running wt -w _quake sp ; sp ; sp from like, the run dialog, or a shortcut, or another Terminal window. Putting the above into startupActions will cause the _quake window to create a new split each and every launch, which would be weird.

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2022
@zadjii-msft zadjii-msft added Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered and removed Issue-Bug It either shouldn't be doing this or needs an investigation. labels Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Answered Related to questions that have been answered
Projects
None yet
Development

No branches or pull requests

2 participants