Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Setting to disable zooming with ctrl+mousewheel #11710

Open
JonnieCache opened this issue Nov 8, 2021 · 14 comments
Open

Request: Setting to disable zooming with ctrl+mousewheel #11710

JonnieCache opened this issue Nov 8, 2021 · 14 comments
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.

Comments

@JonnieCache
Copy link

JonnieCache commented Nov 8, 2021

I would like a setting to disable the zooming/font size changing when scrolling the mousewheel with ctrl held down. The motivation for me is that I have a mouse featuring a clickless wheel with "momentum," which means that windows often get spammed with extraneous wheel events when the wheel is still moving very slightly, resulting in my text getting shrunk down to the smallest possible size when I press ctrl, requiring a reset with ctrl+0.

I know this sounds insane/awful and you're probably thinking I should get a different mouse, but in fact the only annoyance is from wheel zooming in the browser and in the terminal. Regardless of any of this it seems like a generally useful feature. Firefox lets me disable it, and a matching setting in the terminal would be much appreciated.

The ideal implementation would be exposing the wheel events in the Actions pane of configuration, but if this presents architectural challenges a simple toggle in the Interaction pane would of course suffice.

Thanks muchly.

@JonnieCache JonnieCache added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 8, 2021
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 8, 2021
@zadjii-msft
Copy link
Member

note to self: this is not #3990, this is a subset of #1553.

I'll leave this open as an atomic task that's part of the #1553 "scenario". Thanks!

@zadjii-msft zadjii-msft added Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Nov 8, 2021
@zadjii-msft zadjii-msft added this to the Terminal v3.0 milestone Nov 8, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 8, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 17, 2021
@mkorkalo
Copy link

This is indeed very annoying feature. On my laptop, I often find myself zooming in or out accidentally when operating a shell that requires the use of ctrl button.

@OddKMS
Copy link

OddKMS commented Nov 29, 2022

I want to second this, as I've had many an accidental zoom when scrolling up/down with a touchpad. (Doesn't even require the CTRL key to be held down, which is even more annoying.)

@schiorean
Copy link

Any news about this? Completely annoying.

@deadcoder0904
Copy link

2024 update? its really annoying.

i face it every other day. please give us a way to disable zoom-in.

my fonts become really small & then i have to set it to perfect again.

a simple disable boolean would do.

@ChrisHeerschap
Copy link

ChrisHeerschap commented May 16, 2024

Been wishing for this since I started using WT, and looks like I will continue wishing for this. Working in a terminal and accidentally graze the touchpad and suddenly I'm looking at a terminal with a 2 point font. I don't need or want to change my font size on the fly and I imagine there are keyboard shortcuts for this anyway so being able to disable the scroll-zoom would be wonderful.

@lhecker
Copy link
Member

lhecker commented May 16, 2024

It may take a while longer for work on #1553 to be started, and I'd be happy to implement a hotfix for this (for instance with an experimental setting). But can anyone explain how you disable Ctrl+Scroll zooming in Firefox/Chrome/Edge or Visual Studio? In particular the former 3 don't seem to have any keybindings at all, and for the latter I can't find any binding that got Ctrl+Scroll. I'd like to know how other applications do it to have a reference.

@Ayke

This comment has been minimized.

@carlos-zamora carlos-zamora modified the milestones: Up Next, Terminal v1.23 Aug 1, 2024
@AdamDanischewski
Copy link

Took a quick look, the pertinent code seems to be (as of now) on line 504 in src/cascadia/TerminalControl/ControlInteractivity.cpp:

else if (ctrlPressed)
        {
            _mouseZoomHandler(delta);
        }

Could probably hook this to settings?

@ChrisHeerschap
Copy link

Could probably hook this to settings?

That would be fantastic, this unintended zoom happens to me regularly. I'd be perfectly happy with removing that code altogether.

@akamienski
Copy link

Still no update? it's extremely annoying 🙁

@ChrisHeerschap
Copy link

Happens to me several times a week, completely agreed. I just want to be able to disable that ctrl-zoom crap, there are still tons of options for changing the text font that aren't going to happen by accident.

@MohamedMSaeed
Copy link

This is the most ANNOYING part I'm currently facing while using a terminal on Windows!

@gaoqiangks
Copy link

This is the most ANNOYING part I'm currently facing while using a terminal on Windows!

Can't agree more! That'ANNOYINGGGGG!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests