Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow search by Name in the Actions dialog. #11630

Open
Tracked by #10000
anebot opened this issue Oct 27, 2021 · 8 comments
Open
Tracked by #10000

Allow search by Name in the Actions dialog. #11630

anebot opened this issue Oct 27, 2021 · 8 comments
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.

Comments

@anebot
Copy link

anebot commented Oct 27, 2021

Description of the new feature/enhancement

The actions list in the action settings dialog is large, and it's difficult to search for a specific item, so It would be useful to have some search feature, such as an input dialog which allows filter them by name.

Proposed technical implementation details (optional)

Add an input dialog at the top of the dialog which filters the actions list as the user typing.

@anebot anebot added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 27, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 27, 2021
@zadjii-msft
Copy link
Member

Do you mean in the command palette, or in the settings UI?

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal. labels Oct 27, 2021
@anebot
Copy link
Author

anebot commented Oct 27, 2021

Do you mean in the command palette, or in the settings UI?

I mean in the settings dialog.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Oct 27, 2021
@zadjii-msft
Copy link
Member

Oh okay yea, sure that makes sense. IF ONLY WE HAD A HANDY WAY OF FILTERING A LIST OF ACTIONS ALREADY 😝

@zadjii-msft zadjii-msft added Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. labels Oct 27, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 27, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Oct 27, 2021
@anebot
Copy link
Author

anebot commented Oct 28, 2021

Oh okay yea, sure that makes sense. IF ONLY WE HAD A HANDY WAY OF FILTERING A LIST OF ACTIONS ALREADY 😝

Despite your sarcasm, you're likely talking about the command palette 😜. Sure, you can filter actions there, but I don't mean this.

I'm talking, for example, when you want to modify the action's hotkey, it bothers moving from the scroll to look for a specific action. I think It would be easier to have some filtering options in the dialog.

@zadjii-msft
Copy link
Member

Oh that's definitely different. Thanks for helping clarify! There's probably a filterable version of ComboBox we could use for that

@DHowett
Copy link
Member

DHowett commented Oct 28, 2021

Despite your sarcasm, ... i don't mean this

(Feel free to dismiss me if I'm saying something you all already know!¹)

I think Mike's sarcasm was directed towards the project, rather than at you. "If only we had used the thing we already have! Alas! How silly of us!"

(¹ can never be too careful)

@zadjii-msft
Copy link
Member

(^ this is correct)

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 29, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H2, Up Next Nov 28, 2022
@JVimes
Copy link

JVimes commented Mar 3, 2023

This would be great. The settings dialog is approachable which helps adoption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

5 participants