Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Tabs in Quake Mode #11085

Closed
i-love-code opened this issue Aug 30, 2021 · 12 comments
Closed

Show Tabs in Quake Mode #11085

i-love-code opened this issue Aug 30, 2021 · 12 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@i-love-code
Copy link

Description of the new feature/enhancement

When you have the quake-style console open, show the "Tab Bar" above the console so you can visualize & navigate between multiple open consoles.

The only way to do this today is to open the quake console (Win+`) and then use Win+Shift+T to open new tabs and Cntrl+T to navigate between them. It works, but it's almost impossible to know how many consoles/tabs you have open and select the correct one.

gif

Use Case

It's a very common case for local .NET development I'm running:

  • A console at the source control root (for git purposes)
  • A console at (each) .NET project folder (running each "dotnet watch run")
  • A console at (each) frontend application
  • A console for running NPM unit tests

Having each of these in the quake-style console is ideal, which I can do, but I never know which tab is where since you can't see those tabs easily.

Proposed technical implementation details (optional)

Ideally, it would just reuse the existing tab interface of the non-quake windows terminal and remove the top right minimize/maximize UI.

image

@i-love-code i-love-code added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 30, 2021
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 30, 2021
@zadjii-msft
Copy link
Member

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #9992 for more discussion.

/dup #9992

@ghost
Copy link

ghost commented Aug 30, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Aug 30, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 30, 2021
@jrogers512
Copy link

#9992 doesn't look like a duplicate of this. Or at least, it is a much more complex/broad issue than this rather simple one.

As it stands now, while in quake mode:

  • I cannot see what tabs or open, or how many of them are open.
  • I cannot quickly switch to the tab I'd like to (other terminals allow this by pressing alt+window number, or allow you to click on the tab. We cannot see the tab in the quake window, so there is nothing to click)
  • when pressing Ctrl-D, typing exit, or logout, you see [process exited with code 127], but there is no way to close the tab (again, since I cannot see the tab at the top of the window, there is no option to select an X to close the tab, or right click the tab)

@zadjii-msft
Copy link
Member

It's a little confusing how #9992 gets what you want, but lemme try to clarify:

  • The _quake window is a kind of special window right now. Imagine that it has properties launchMode:focus, snapTo:top, minimizeToTray:true set.
  • Add per-window-name global settings #9992 will let you change the properties for certain window names. So that would let you remove the launchMode:focus aspect of the _quake window.
  • You can always just bind win+` to a plain-old globalSummon action. The terminal won't automatically snap to the top like the _quake window does, but we'll add that feature soontm
  • In the _quake window, you can always leave focus mode with the Command Palette (on Ctrl+Shift+P)
  • You can always close tabs with Ctrl+Shift+w
  • You can already switch to various tabs with Ctrl+alt+1-9
  • with "tabSwitcherMode": "inOrder", or "tabSwitcherMode": "mru", the tab switcher on Ctrl+tab will show you a list of tabs

Did I miss anything?

@ninjasitm
Copy link

ninjasitm commented Dec 21, 2021

Hello,

I'd like to say that we appreicate the work done on this project. It has come a long way and is absolutely getting better with every release.

However the solution proposed here is very ineligant.

A simple tab bar as described by @i-love-code would be the most efficent solution. For reference check out the solution implemented here https://github.com/flyingpie/windows-terminal-quake which does provide this UI.

@i-love-code
Copy link
Author

i-love-code commented Dec 22, 2021

For @ninjasitm and @jrogers512 and anyone finding this thread later:

I also don't agree with "Quake" mode not a better UI natively, but here's a quick workaround that works super well. It's not well documented but you can open the Quake mode and then Control + Shift + P which brings up the command palette inside the quake window and you search for "Focus" and you'll find an option called Toggle Focus Mode. It brings up tabs in the quake mode.

The setting doesn't get saved and it's super annoying to enable each time, but it is what it is.

@vaduveerappan
Copy link

vaduveerappan commented Jan 22, 2022

You could also set the shortcut for the Toggle Focus mode on your settings.json to make @i-love-code suggestion easier
{ "command": "toggleFocusMode", "keys": "shift+f12" },

@NSurtsev
Copy link

NSurtsev commented Feb 4, 2022

Tabs in Quake mode should be displayed like in Linux, in the bottom of Quake-Terminal.
Just copy Linux. Everything has already been invented years ago.

@sryze
Copy link

sryze commented Apr 9, 2022

I think the placement of tabs should be configurable, e.g. top or bottom, or hide them altogether / hide when only one tab is open (for tmux users).

@zadjii-msft
Copy link
Member

@sryze We're tracking that in #835 and #7210, go 👍 those 😉

@zohozer
Copy link

zohozer commented Sep 24, 2022

I accidentaly got into this Quake mode and I can't find any way to return to the normal windows. How to disable this mode?

@b-hayes
Copy link

b-hayes commented Jun 24, 2023

quake mode should just be a normal terminal that appears at from the top. No need for it to be different in any way. Its pretty silly not having the tabs in the first place imo. The so called duplicate issues seem to be covering a lot more than simply keeping tabs visible in quake mode. No need to customize them or do anything special just dont hide the tabs in quake mode.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

9 participants