Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent handling of built-in color schemes #10888

Closed
mrjoel opened this issue Aug 6, 2021 · 2 comments
Closed

Inconsistent handling of built-in color schemes #10888

mrjoel opened this issue Aug 6, 2021 · 2 comments
Labels
Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@mrjoel
Copy link

mrjoel commented Aug 6, 2021

Windows Terminal version (or Windows build number)

1.9.1942.0

Other Software

No response

Steps to reproduce

  • Edit a built-in color scheme through the UI
  • Save settings

Expected Behavior

I would expect that built-in color schemes are protected/invariant/read-only. Further, I store my settings.json in a dotfiles git repo and the built-in color schemes are a) just fine for my needs, but b) amount to nothing but litter in the config file.

In my mind, ideally the following changes would address this apparent inconsistency.

  • Don't save the built-in color schemes to settings.json (they're built-in, why pollute the user config file?)
  • Don't allow editing of a built-in color scheme.
  • Provide an option to save a copy of a built-in (or any) color scheme as a different user name.

At the very least an option should be provided to revert a modified built-in color scheme back to the built-in defaults (i.e. reset to match the original), but that seems odd because all of the potential time using a derivative built-in.

Actual Behavior

The color scheme settings UI section indicates that "This color scheme cannot be deleted or renamed because it is included by default.". However the schemes are saved out to the settings.json, and editing of the scheme is allowed. However once a built-in color scheme is edited, it a) doesn't match the expected colors and yet still proclaims the same built-in name, and b) there is no way to reset the color scheme to the originals expect removing the named color scheme from the array in settings.json.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 6, 2021
@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Aug 10, 2021
@zadjii-msft
Copy link
Member

Okay after re-reading this, I actually think this is just going to get fixed by #8100. I know it doesn't sound like it, but with 8100, we won't need to keep reserializing builtin schemes back out. Sorry for the delay getting back here!

/dup #8100

@ghost
Copy link

ghost commented Nov 16, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 16, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 16, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants