Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build failure with react-native 0.56 (The SDK Build Tools revision (23.0.1) is too low) #1336

Closed
krystofbe opened this issue Jul 5, 2018 · 8 comments

Comments

@krystofbe
Copy link

Steps to Reproduce

  1. Upgrade to react-native 0.56 according to https://facebook.github.io/react-native/docs/upgrading.html
  2. Clean everything
  3. run react-native run-android

Expected Behavior

Build to run successfuilly

Actual Behavior

What actually happens?

 FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':app'.
> Could not resolve all dependencies for configuration ':app:_debugApk'.
   > A problem occurred configuring project ':react-native-code-push'.
      > The SDK Build Tools revision (23.0.1) is too low for project ':react-native-code-push'. Minimum required is 25.0.0

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

Environment

  • react-native-code-push version: react-native-code-push@^5.3.4:
  • react-native version: react-native@0.56.0
  • iOS/Android/Windows version: Nexus_5X_API_23
  • Does this reproduce on a debug build or release build? debug
  • Does this reproduce on a simulator, or only on a physical device? simulator
@alexandergoncharov-zz
Copy link
Contributor

Hi @krystofbe ,
Thanks for reporting!

Yeah, it is so because react-native has updated buildTools in @0.56 version. It is known issue. Fix in progress.

Thanks,
Alexander

@mouthzipper
Copy link

+1

@krystofbe
Copy link
Author

"fixed" this by editing my build.gradle

subprojects {
   afterEvaluate {
     project -> if (project.hasProperty("android")) {
       android {
            compileSdkVersion 26
            buildToolsVersion "26.0.3"
       }
      }
    }
}

@alexandergoncharov-zz
Copy link
Contributor

Hi @krystofbe and @mouthzipper

Created PR for this: #1342
Could you please test it when you get the chance?

Thanks,
Alexander

@xaviraol
Copy link

xaviraol commented Jul 9, 2018

Hi @alexandergoncharov
Would it be possible to use the proposed approach here?

@alexandergoncharov-zz
Copy link
Contributor

Hi @xaviraol,

Do you mean use project-wide properties? Yeah, It is good approach. Thanks for this.

@alexandergoncharov-zz
Copy link
Contributor

Hi all,

#1342 is updates with project-wide properties.

@alexandergoncharov-zz
Copy link
Contributor

Hi all,

I'm going to close this issue as fix in master and already in new release.
Please feel free to reopen it if you have any questions or you face this issue again.

Thanks,
Alexander

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants