Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loading Quilla options from config file #49

Open
cryptaliagy opened this issue Jul 21, 2021 · 0 comments
Open

Add support for loading Quilla options from config file #49

cryptaliagy opened this issue Jul 21, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@cryptaliagy
Copy link
Collaborator

Several frameworks and tools related to testing also include the ability to configure themselves through a configuration file of some sort. This allows users to not have to save their command-line options through aliases/scripts/etc, but still allow configs to be persistent.

An example of this is Pytest, which searches for one of a few possible config files and a root directory. This is explained in further detail here: https://docs.pytest.org/en/6.2.x/customize.html#config-file-formats

Other tools that do this include tox, mypy, flake8, etc.

Quilla could benefit from something similar, which would even allow configs to be versioned in VCS.

This functionality could be done as either a plugin, or alternatively it could be handled similarly to how Pytest does it. The latter option would require the whole parsing/config system that Quilla uses to be overhauled by making a new Parser class that would abstract adding cofig file options and CLI options, which is admittedly more work.

As a practical example, the Pytest Argument Parser can be found here: https://github.com/pytest-dev/pytest/blob/main/src/_pytest/config/argparsing.py . It might be helpful to see how they did it, since Quilla uses the same plugin library.

Some considerations with this ticket:

  • What language should the config file be written in? YAML, INI, TOML, JSON, etc. are various options, each with their own benefits and drawbacks
  • How will this configuration file integrate with the existing pytest-quilla plugin? Would we use a setup.cfg file system like flake8/mypy/pytest, or would we want to keep our files separate?
  • Do we actually want to support config files? Currently, the only way to configure Quilla is done through CLI options or alternatively through plugins (uiconf.py file/installed plugins). If this is good enough, we can label it as such but we should consider whether or not this is something worth supporting.
@cryptaliagy cryptaliagy added the enhancement New feature or request label Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant