Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add Parser Support for Invalid Syntax Literals #154

Open
bgribaudo opened this issue May 13, 2020 · 3 comments
Open

[Enhancement] Add Parser Support for Invalid Syntax Literals #154

bgribaudo opened this issue May 13, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@bgribaudo
Copy link
Contributor

Describe the solution you'd like
Power Query expressions can contain "invalid syntax literals" (unsure the official name), a syntax construct in the form of #!" … " which is not mentioned in the official language specification.

To enable this parser to fully parse the section documents created by Microsoft Excel and Power BI, both of which can output invalid syntax literals, would it make sense to extend the parser to support these literals?

Example (pulled verbatim from a Power BI file):

section Section1;

shared Query1 = let
    Source = #!"let a"
in
    Source;

Additional context
For more details on these literals, see https://github.com/MicrosoftDocs/powerquery-docs/issues/12.

@bgribaudo bgribaudo added the enhancement New feature or request label May 13, 2020
@JordanBoltonMN
Copy link
Contributor

It's not the highest priority but I don't think it'll be difficult to implement.. I'll look into it once I'm back in office.

@JordanBoltonMN
Copy link
Contributor

It should be relatively easy to implement, but is marked as low priority as users won't run into a the verbatim literal in a regular work flow.

@bgribaudo
Copy link
Contributor Author

Sounds good. Thank you, @JordanBoltonMN!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants