Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Quoted identifiers don't autocomplete as expected while typing #217

Open
JordanBoltonMN opened this issue Feb 8, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@JordanBoltonMN
Copy link
Contributor

Expected behavior
I was testing some things in the language services layer. Take for example the following setup:

let
    foo.bar = 1,
    #"unneededQuote" = 2,
    #"quoted identifier" = 3
in
    |
  • With no text it has the following recommendations: foo.bar, unneededQuote, #"uneededQuote", and #"quoted identifier".
  • With foo. for text it has the following recommendations: foo.bar
  • With any subset of a quoted identifier (eg. #, #", #"", etc) it should recommend the quoted identifier.

Actual behavior

  • With no text it has the following recommendations: foo.bar, unneededQuote, #"uneededQuote", and #"quoted identifier".
  • With foo. for text it has the following recommendations: foo.bar
  • With any subset of a quoted identifier (eg. #, #", #"", etc) it does not recommend anything.

To Reproduce
See the setup in expected behavior

Additional context
The initial hurdle is the lexer will fail to lex if it encounters a trailing #, as it's attempting to read a keyword but fails. Instead I might want to attempt to read a keyword but fallback in starting a quoted identifier. Additionally we might need to tweak the trailing token logic to include quoted identifiers.

@JordanBoltonMN JordanBoltonMN added the bug Something isn't working label Feb 8, 2023
@JordanBoltonMN JordanBoltonMN self-assigned this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant