Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run client-certificate tests in service mode #31973

Conversation

mxschmitt
Copy link
Member

No description provided.

@mxschmitt mxschmitt force-pushed the run-client-certificate-tests-in-service-mode branch from 0c3f352 to 5b37e7d Compare August 1, 2024 20:48

This comment has been minimized.

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the run-client-certificate-tests-in-service-mode branch from 5b37e7d to 1ad450a Compare August 1, 2024 21:16
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Test results for "tests 1"

1 failed
❌ [playwright-test] › web-server.spec.ts:90:5 › should create a server with environment variables

6 flaky ⚠️ [chromium-library] › library/page-clock.spec.ts:343:3 › popup › should not run time before popup on pause
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/capabilities.spec.ts:141:3 › should not crash on showDirectoryPicker
⚠️ [chromium-library] › library/trace-viewer.spec.ts:248:1 › should have network requests
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:165:5 › should update tracing network live
⚠️ [playwright-test] › ui-mode-test-attachments.spec.ts:102:5 › should linkify string attachments

29516 passed, 702 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt added the CQ1 label Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Test results for "tests others"

2 flaky ⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots

17861 passed, 482 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Test results for "tests 2"

4 fatal errors, not part of any test
7 failed
❌ [chromium-library] › library/browsertype-connect.spec.ts:665:5 › run-server › should fulfill with global fetch result
❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:502:7 › cli codegen › should save assets via SIGINT
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [webkit-library] › library/video.spec.ts:381:5 › screencast › should capture navigation

117 flaky ⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1167:3 › should work with connectOverCDP
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:311:5 › launchServer › should handle exceptions during connect
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:681:5 › run-server › should upload large file
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:734:5 › run-server › setInputFiles should preserve lastModified timestamp
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context
⚠️ [chromium-library] › library/download.spec.ts:391:5 › download event › should delete downloads on browser gone
⚠️ [chromium-library] › library/downloads-path.spec.ts:32:5 › downloads path › should keep downloadsPath folder
⚠️ [chromium-library] › library/har.spec.ts:82:3 › should have pages in persistent context
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should work with --save-har
⚠️ [chromium-library] › library/tracing.spec.ts:189:5 › should respect tracesDir and name
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:145:12 › should drag with high dpi
⚠️ [chromium-page] › page/page-mouse.spec.ts:211:3 › should tween mouse movement
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:22:7 › cli codegen › should click locator.first
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:422:5 › launchServer › should reject waitForEvent before browser.onDisconnect fires
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1091:1 › should ignore 304 responses
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/capabilities.spec.ts:260:3 › requestFullscreen
⚠️ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:331:3 › should emulate media in cross-process iframe
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:19:3 › should not hit scroll bar
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:331:3 › should emulate media in cross-process iframe
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox-library] › library/video.spec.ts:760:5 › screencast › should capture full viewport on hidpi
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [firefox-page] › page/page-mouse.spec.ts:147:3 › should select the text with mouse
⚠️ [firefox-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [firefox-page] › page/page-mouse.spec.ts:176:3 › should trigger hover state on disabled button
⚠️ [firefox-page] › page/page-screenshot.spec.ts:665:5 › page screenshot animations › should resume infinite animations
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:502:7 › cli codegen › should check with keyboard
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:752:7 › cli codegen › should record slider
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:138:7 › cli codegen › should upload multiple files
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:169:7 › cli codegen › should clear files
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:45:5 › should print the correct context options for custom settings
⚠️ [firefox-library] › library/tracing.spec.ts:380:5 › should not stall on dialogs
⚠️ [firefox-library] › library/tracing.spec.ts:486:5 › should work with multiple chunks
⚠️ [firefox-library] › library/tracing.spec.ts:551:5 › should ignore iframes in head
⚠️ [firefox-page] › page/page-click.spec.ts:97:3 › should click the 1x1 div
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-page] › page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1167:3 › should work with connectOverCDP
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:262:5 › launchServer › should support slowmo option
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:838:7 › run-server › socks proxy › should proxy local.playwright requests
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context
⚠️ [chromium-library] › library/defaultbrowsercontext-2.spec.ts:198:3 › should respect selectors
⚠️ [chromium-library] › library/har.spec.ts:82:3 › should have pages in persistent context
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should work with --save-har
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log @smoke
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:145:12 › should drag with high dpi
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:704:7 › cli codegen › should assert value on disabled select
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [webkit-library] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [webkit-page] › page/page-goto.spec.ts:329:3 › should fail when navigating to bad SSL after redirects
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:553:7 › cli codegen › should select
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:442:7 › cli codegen › should reset hover model on action when element detaches
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:502:7 › cli codegen › should generate getByLabel without regex
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [webkit-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:40:3 › should upload a folder
⚠️ [webkit-library] › library/browsercontext-viewport.spec.ts:145:12 › should drag with high dpi
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:632:7 › cli codegen › should assert value
⚠️ [webkit-page] › page/page-mouse.spec.ts:211:3 › should tween mouse movement
⚠️ [webkit-page] › page/workers.spec.ts:243:3 › should support offline
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:607:5 › run-server › should save har
⚠️ [webkit-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:40:3 › should upload a folder

225430 passed, 9656 skipped, 2794 did not run
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit f17de82 into microsoft:main Aug 2, 2024
103 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants