feat(plugins): send accept header in webServer url checking #16251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The test failures seem to be completely unrelated, from what I can tell. Is there anything I can do to help this PR to get a review? |
rwoll
suggested changes
Aug 9, 2022
ghost91-
force-pushed
the
send-accept-header-in-webserver-requests
branch
from
3e8956f
to
51a5b47
Compare
rwoll
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the Accept HTTP header to
*/*for HTTP requests made by the webServer plugin when using a URL to check if the server has already started. So far, the Accept header was not being sent at all, which should be semantically equivalent to sending*/*, according to RFC 7231. However, there are some web servers that handle this differently. Most notably, Vite's server just returns a 404 if theAcceptheader is missing from the request. I created vitejs/vite#9520 in order to address the issue on their side, but I think it's also fine to just add the header here, which is why I created this PR.