DirectML.dll load fails when executable path contains Non-English characters #9229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 30, 2021 09:48
smk2007
requested review from
tiagoshibata,
ryanlai2,
zhangxiang1993 and
martinb35
martinb35
reviewed
Sep 30, 2021
martinb35
reviewed
Sep 30, 2021
martinb35
approved these changes
Sep 30, 2021
tiagoshibata
approved these changes
Sep 30, 2021
| auto out_path = std::string(absolute_path); | ||
| out_path.resize(idx); | ||
| auto idx = std::distance(absolute_path, name); | ||
| auto out_path = std::wstring(absolute_path); |
There was a problem hiding this comment.
I think auto out_path = std::wstring(absolute_path, idx); does one copy with the right size
smk2007
added a commit
that referenced
this pull request
Sep 30, 2021
…racters (#9229) * enable unicode dml * add wide string L prefix * Add Fail Fast back Co-authored-by: Sheil Kumar <sheilk@microsoft.com>
smk2007
added a commit
that referenced
this pull request
Oct 1, 2021
* Add full iOS job in package pipeline (#9036) * Add full ios xcframework job * create zip file of the xcframework * Bump up TVM version to avoid conflict with existing one (#9159) * Bump up tvm version * Bump up onnxruntime-tvm version There are some c++17 related fixes in TVM Co-authored-by: KeDengMS <kedeng@microsoft.com> * fix bug introduced by PR9130 (#9166) * make uwp store apps link to statically-linked crt desktop builds (#9182) Co-authored-by: Sheil Kumar <sheilk@microsoft.com> * #9182 removed the `--is_store_build` option but one place where that was used was missed. (#9219) This should fix the relevant packaging pipelines. * DirectML.dll load fails when executable path contains Non-English characters (#9229) * enable unicode dml * add wide string L prefix * Add Fail Fast back Co-authored-by: Sheil Kumar <sheilk@microsoft.com> * Fix Android build break after Virtual Environment update to 20210919 (#9163) Co-authored-by: Guoyu Wang <62914304+gwang-msft@users.noreply.github.com> Co-authored-by: ke1337 <22626095+ke1337@users.noreply.github.com> Co-authored-by: KeDengMS <kedeng@microsoft.com> Co-authored-by: George Wu <jywu@microsoft.com> Co-authored-by: Sheil Kumar <sheilk@microsoft.com> Co-authored-by: Scott McKay <skottmckay@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DirectML.dll load fails when executable path contains Non-English characters
Issue: DirectML.dll is loaded with LoadLibraryExA when it should be using LoadLibraryExW
Test: Windows AI builds correctly and loads correctly when built exes are run from paths containing unicode:
https://aiinfra.visualstudio.com/Lotus/_build/results?buildId=176800&view=results