fix memory profile build #16177
Merged
fix memory profile build #16177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
approved these changes
May 31, 2023
|
/azp run onnxruntime-binary-size-checks-ci-pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
You can merge it now. The DNNL pipeline failure is not related to your change. |
|
Working with @jslhcl to make sure this not only fixes the build but also provides working functionality of memory profiling. This was refactored so important to test. Original version only worked by default on GPU but had internal CPU support. |
|
@jslhcl , does the problem exist in ORT 1.15.0 release? |
snnn
pushed a commit
that referenced
this pull request
Jun 15, 2023
### Description <!-- Describe your changes. --> This PR is to fix the build break when onnxruntime_ENABLE_MEMORY_PROFILE is on ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> This PR is to fix the build break when onnxruntime_ENABLE_MEMORY_PROFILE is on. It fixes this issue #16124 Co-authored-by: Lei Cao <leca@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to fix the build break when onnxruntime_ENABLE_MEMORY_PROFILE is on
Motivation and Context
This PR is to fix the build break when onnxruntime_ENABLE_MEMORY_PROFILE is on.
It fixes this issue #16124