-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DML EP] Contrib Op: FusedMatMul #12898
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdwr
reviewed
Sep 8, 2022
onnxruntime/core/providers/dml/DmlExecutionProvider/src/TensorDesc.cpp
Outdated
Show resolved
Hide resolved
fdwr
reviewed
Sep 8, 2022
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorHelper.cpp
Outdated
Show resolved
Hide resolved
fdwr
requested changes
Sep 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some robustness checks for span copies.
fdwr
reviewed
Sep 8, 2022
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorHelper.cpp
Outdated
Show resolved
Hide resolved
fdwr
reviewed
Sep 8, 2022
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorHelper.cpp
Outdated
Show resolved
Hide resolved
fdwr
reviewed
Sep 9, 2022
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorHelper.cpp
Outdated
Show resolved
Hide resolved
fdwr
reviewed
Sep 9, 2022
fdwr
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fused*
toDmlFused*
. It is needed to avoid the name overlapping betweenORT Contrib operator FusedMatMul
andDML fused operator FusedMatMul (now this is DmlFusedMatMul)
trans
andtransBatch
by manipulating the input shapes and generating the appropriate strides.trans
: transpose the last 2 dimensions.transBatch
: shift the batch dimensions (all dimensions expect the last 2 dimensions) by 1 and move the 2nd-last dimension to the place of 1st dimension.transBatch
andtrans
, applytransBatch
first and thentrans
trans
ortransBatch
is present, and those strides should not be overridden).DmlOperator::TensorDesc
because as mentioned above actual input shapes need to be manipulated to acknowledge the 2 types of transposes. That's why I added a new way to initialize a DMLOperator viaDmlOperator::InitializeWithShape
winml_test_model.exe
successfully passes, which verifies nothing breaks because Dml fused operator re-naming.Motivation and Context
This contrib operator is used by transformer-based models.