Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

register signal ops for opset 17 #11778

Merged
merged 20 commits into from
Jun 27, 2022
Merged

register signal ops for opset 17 #11778

merged 20 commits into from
Jun 27, 2022

Commits on Jun 24, 2022

  1. Register signal ops for op set 17 

    Note code is mostly being moved, not added. These ops were previously
only registered as Microsoft contrib ops and only built if
`BUILD_MS_EXPERIMENTAL_OPS=1`. They've been added to the ai.onnx
standard op set in version 17.

Main components of this change:

* Move the kernels from the conrib_ops directory to the
  core directory.
* Add function bodies for ms experimental ops. This will allow
  old models that use the contrib ops to continue to function.
  All the function bodies consist of a single op (the
  new standard op), so performance overhead should be minimal.

Minor clean-up also in this change:

* De-duplicate get_scalar_value_from_tensor: put it in a new utils.h.
* Fix some bugs that caused compilation errors with the experimental
  ops. Tested with `build.sh --ms_experimental`
* Fix some spelling errors and lint violations.
* Replace a couple of switch statements with `MLTypeCallDispatcher`.
* Use `InlineVector` instead of `std::vector`.

Unblocks microsoft#11640
    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    c713b09 View commit details
    Browse the repository at this point in the history

  2. undo formatting changes to cpu_execution_provider.cc

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    63a179b View commit details
    Browse the repository at this point in the history

  3. add trailing new line

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    718faea View commit details
    Browse the repository at this point in the history

  4. code review comments

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    183477e View commit details
    Browse the repository at this point in the history

  5. Delete experimental op schemas.

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    6f925e1 View commit details
    Browse the repository at this point in the history

  6. simplify get_scalar_value_from_tensor

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    1a380b3 View commit details
    Browse the repository at this point in the history

  7. move compute_exponential to a helper

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    492b957 View commit details
    Browse the repository at this point in the history

  8. Update OperatorKernels.md

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    82c0eed View commit details
    Browse the repository at this point in the history

  9. move tests

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    c736ed6 View commit details
    Browse the repository at this point in the history

  10. fix input order

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    0d1765c View commit details
    Browse the repository at this point in the history

  11. dpnt use a switch statement for bit_reverse

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    dbb3e2f View commit details
    Browse the repository at this point in the history

  12. test that FFT is invertible

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    02fc960 View commit details
    Browse the repository at this point in the history

  13. Enable tests

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    529add6 View commit details
    Browse the repository at this point in the history

  14. Fix get_scalar_value_from_tensor

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    1ecaa63 View commit details
    Browse the repository at this point in the history

  15. Support periodic attribute

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    01a1ccc View commit details
    Browse the repository at this point in the history

  16. simplify test

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    283ed5c View commit details
    Browse the repository at this point in the history

  17. check for out of bounds access

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    7f33088 View commit details
    Browse the repository at this point in the history

  18. update OperatorKernels.md

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    e808844 View commit details
    Browse the repository at this point in the history

  19. remove bounds check, it did not fire

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    e27222f View commit details
    Browse the repository at this point in the history

  20. fix onesided destination overflow

    @garymm
    garymm committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    e6ec47e View commit details
    Browse the repository at this point in the history