Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCm Conv is not thread safe #21311

Open
tianleiwu opened this issue Jul 10, 2024 · 0 comments
Open

ROCm Conv is not thread safe #21311

tianleiwu opened this issue Jul 10, 2024 · 0 comments
Labels
ep:ROCm questions/issues related to ROCm execution provider

Comments

@tianleiwu
Copy link
Contributor

tianleiwu commented Jul 10, 2024

Describe the issue

The cache of conv algorithm finding result is not guarded by mutex like here the cache is clear but other thread might still use the cache.

The cache only uses x shape as key. If w shape changes, cache might lead to invalid algorithm (the cached algo is for another w shape) which causes MIOpen Error: No invoker was registered for convolution forward error. Another issue might be related to this: #19566

To reproduce

See the issue reported here:
#19567 (comment)

Urgency

No response

Platform

Linux

OS Version

ubuntu 20.04

ONNX Runtime Installation

Built from Source

ONNX Runtime Version or Commit ID

1.18.1

ONNX Runtime API

Python

Architecture

X64

Execution Provider

Other / Unknown

Execution Provider Library Version

ROCm 6.0

@github-actions github-actions bot added the ep:ROCm questions/issues related to ROCm execution provider label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:ROCm questions/issues related to ROCm execution provider
Projects
None yet
Development

No branches or pull requests

1 participant