Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile error on Windows with Electron 6 #329

Closed
bpasero opened this issue Jul 6, 2019 · 3 comments · Fixed by #331
Closed

Compile error on Windows with Electron 6 #329

bpasero opened this issue Jul 6, 2019 · 3 comments · Fixed by #331
Assignees
@deepak1556 @Tyriar
Milestone
0.9.0

Comments

@bpasero
Copy link
Member

bpasero commented Jul 6, 2019

Looks like the latest beta does not compile on Windows:

Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  conpty.cc
  path_util.cc
  win_delay_load_hook.cc
c:\users\bpasero\.node-gyp\6.0.0-beta.12\include\node\v8.h(8207): warning C4996: 'v8::MicrotasksCompletedCallback': was declared deprecated (compiling source file ..\src\win\conpty.cc) [C:\GitDevelopment\monaco\node_modules\node-pty\build\conpty.vcxproj]
  c:\users\bpasero\.node-gyp\6.0.0-beta.12\include\node\v8.h(6668): note: see declaration of 'v8::MicrotasksCompletedCallback' (compiling source file ..\src\win\conpty.cc)
c:\users\bpasero\.node-gyp\6.0.0-beta.12\include\node\v8.h(8216): warning C4996: 'v8::MicrotasksCompletedCallback': was declared deprecated (compiling source file ..\src\win\conpty.cc) [C:\GitDevelopment\monaco\node_modules\node-pty\build\conpty.vcxproj]
  c:\users\bpasero\.node-gyp\6.0.0-beta.12\include\node\v8.h(6668): note: see declaration of 'v8::MicrotasksCompletedCallback' (compiling source file ..\src\win\conpty.cc)
c:\users\bpasero\.node-gyp\6.0.0-beta.12\include\node\v8.h(8207): warning C4996: 'v8::MicrotasksCompletedCallback': was declared deprecated (compiling source file ..\src\win\path_util.cc) [C:\GitDevelopment\monaco\node_modules\node-pty\build\conpty.vcxproj]
  c:\users\bpasero\.node-gyp\6.0.0-beta.12\include\node\v8.h(6668): note: see declaration of 'v8::MicrotasksCompletedCallback' (compiling source file ..\src\win\path_util.cc)
c:\users\bpasero\.node-gyp\6.0.0-beta.12\include\node\v8.h(8216): warning C4996: 'v8::MicrotasksCompletedCallback': was declared deprecated (compiling source file ..\src\win\path_util.cc) [C:\GitDevelopment\monaco\node_modules\node-pty\build\conpty.vcxproj]
  c:\users\bpasero\.node-gyp\6.0.0-beta.12\include\node\v8.h(6668): note: see declaration of 'v8::MicrotasksCompletedCallback' (compiling source file ..\src\win\path_util.cc)
..\src\win\conpty.cc(177): error C2664: 'v8::Local<v8::Boolean> v8::Value::ToBoolean(void) const': cannot convert argument 1 from 'v8::Local<v8::Context>' to 'v8::Isolate *' [C:\GitDevelopment\monaco\node_modules\node-pty\build\conpty.vcxproj]
  ..\src\win\conpty.cc(177): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
..\src\win\conpty.cc(177): error C2228: left of '.ToLocalChecked' must have class/struct/union [C:\GitDevelopment\monaco\node_modules\node-pty\build\conpty.vcxproj]
..\src\win\conpty.cc(177): error C2227: left of '->IsTrue' must point to class/struct/union/generic type [C:\GitDevelopment\monaco\node_modules\node-pty\build\conpty.vcxproj]
..\src\win\conpty.cc(177): error C2789: 'debug': an object of const-qualified type must be initialized [C:\GitDevelopment\monaco\node_modules\node-pty\build\conpty.vcxproj]
  ..\src\win\conpty.cc(177): note: see declaration of 'debug'
..\src\win\conpty.cc(179): error C2664: 'v8::Local<v8::Boolean> v8::Value::ToBoolean(void) const': cannot convert argument 1 from 'v8::Local<v8::Context>' to 'v8::Isolate *' [C:\GitDevelopment\monaco\node_modules\node-pty\build\conpty.vcxproj]
  ..\src\win\conpty.cc(179): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
..\src\win\conpty.cc(179): error C2228: left of '.ToLocalChecked' must have class/struct/union [C:\GitDevelopment\monaco\node_modules\node-pty\build\conpty.vcxproj]
..\src\win\conpty.cc(179): error C2227: left of '->IsTrue' must point to class/struct/union/generic type [C:\GitDevelopment\monaco\node_modules\node-pty\build\conpty.vcxproj]
..\src\win\conpty.cc(179): error C2789: 'inheritCursor': an object of const-qualified type must be initialized [C:\GitDevelopment\monaco\node_modules\node-pty\build\conpty.vcxproj]
  ..\src\win\conpty.cc(179): note: see declaration of 'inheritCursor'
  conpty_console_list.cc
  win_delay_load_hook.cc
c:\users\bpasero\.node-gyp\6.0.0-beta.12\include\node\v8.h(8207): warning C4996: 'v8::MicrotasksCompletedCallback': was declared deprecated (compiling source file ..\src\win\conpty_console_list.cc) [C:\GitDevelopment\monaco\node_modules\node-pty\build\conpty_console_list.vcxproj]
  c:\users\bpasero\.node-gyp\6.0.0-beta.12\include\node\v8.h(6668): note: see declaration of 'v8::MicrotasksCompletedCallback' (compiling source file ..\src\win\conpty_console_list.cc)
c:\users\bpasero\.node-gyp\6.0.0-beta.12\include\node\v8.h(8216): warning C4996: 'v8::MicrotasksCompletedCallback': was declared deprecated (compiling source file ..\src\win\conpty_console_list.cc) [C:\GitDevelopment\monaco\node_modules\node-pty\build\conpty_console_list.vcxproj]
  c:\users\bpasero\.node-gyp\6.0.0-beta.12\include\node\v8.h(6668): note: see declaration of 'v8::MicrotasksCompletedCallback' (compiling source file ..\src\win\conpty_console_list.cc)
     Creating library C:\GitDevelopment\monaco\node_modules\node-pty\build\Release\conpty_console_list.lib and object C:\GitDevelopment\monaco\node_modules\node-pty\build\Release\conpty_console_list.exp
  conpty_console_list.vcxproj -> C:\GitDevelopment\monaco\node_modules\node-pty\build\Release\\conpty_console_list.node
  conpty_console_list.vcxproj -> C:\GitDevelopment\monaco\node_modules\node-pty\build\Release\conpty_console_list.pdb (Full PDB)
@deepak1556 deepak1556 mentioned this issue Jul 6, 2019
Merged
@Tyriar Tyriar added this to the 0.9.0 milestone Jul 6, 2019
@bpasero
Copy link
Member Author

bpasero commented Jul 7, 2019

@Tyriar is that available in "node-pty": "^0.9.0-beta19"? I tried and got this:

error /__w/1/s/node_modules/node-pty: Command failed.
Exit code: 1
Command: node scripts/install.js
Arguments: 
Directory: /__w/1/s/node_modules/node-pty
Output:
gyp info it worked if it ends with ok
gyp info using node-gyp@3.8.0
gyp info using node@10.15.1 | linux | x64
gyp info spawn /usr/bin/python2
gyp info spawn args [ '/__t/node/10.15.1/x64/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/__w/1/s/node_modules/node-pty/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/__t/node/10.15.1/x64/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12',
gyp info spawn args   '-Dnode_gyp_dir=/__t/node/10.15.1/x64/lib/node_modules/npm/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=/home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/<(target_arch)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=/__w/1/s/node_modules/node-pty',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.' ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
make: Entering directory `/__w/1/s/node_modules/node-pty/build'
  CXX(target) Release/obj.target/pty/src/unix/pty.o
In file included from /home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/v8-internal.h:14:0,
                 from /home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/v8.h:25,
                 from /home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/node.h:63,
                 from ../../nan/nan.h:54,
                 from ../src/unix/pty.cc:20:
/home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/v8config.h:326:49: warning: 'MicrotasksCompletedCallback' is deprecated [-Wdeprecated-declarations]
   declarator __attribute__((deprecated(message)))
                                                 ^
/home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/v8.h:8205:3: note: in expansion of macro 'V8_DEPRECATE_SOON'
   V8_DEPRECATE_SOON("Use *WithData version.",
   ^
/home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/v8config.h:326:49: warning: 'MicrotasksCompletedCallback' is deprecated [-Wdeprecated-declarations]
   declarator __attribute__((deprecated(message)))
                                                 ^
/home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/v8.h:8214:3: note: in expansion of macro 'V8_DEPRECATE_SOON'
   V8_DEPRECATE_SOON("Use *WithData version.",
   ^
../src/unix/pty.cc: In function 'Nan::NAN_METHOD_RETURN_TYPE PtyFork(Nan::NAN_METHOD_ARGS_TYPE)':
../src/unix/pty.cc:195:53: error: no matching function for call to 'v8::Value::BooleanValue(v8::Local<v8::Context>)'
   if (info[8]->BooleanValue(Nan::GetCurrentContext()).FromJust()) {
                                                     ^
../src/unix/pty.cc:195:53: note: candidates are:
In file included from /home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/node.h:63:0,
                 from ../../nan/nan.h:54,
                 from ../src/unix/pty.cc:20:
/home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/v8.h:2532:8: note: bool v8::Value::BooleanValue(v8::Isolate*) const
   bool BooleanValue(Isolate* isolate) const;
        ^
/home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/v8.h:2532:8: note:   no known conversion for argument 1 from 'v8::Local<v8::Context>' to 'v8::Isolate*'
In file included from /home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/v8-internal.h:14:0,
                 from /home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/v8.h:25,
                 from /home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/node.h:63,
                 from ../../nan/nan.h:54,
                 from ../src/unix/pty.cc:20:
/home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/v8.h:2541:43: note: bool v8::Value::BooleanValue() const
   V8_DEPRECATED("Use maybe version", bool BooleanValue() const);
                                           ^
/home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/v8config.h:311:3: note: in definition of macro 'V8_DEPRECATED'
   declarator __attribute__((deprecated(message)))
   ^
/home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/v8.h:2541:43: note:   candidate expects 0 arguments, 1 provided
   V8_DEPRECATED("Use maybe version", bool BooleanValue() const);
                                           ^
/home/vsts_azpcontainer/.node-gyp/6.0.0-beta.12/include/node/v8config.h:311:3: note: in definition of macro 'V8_DEPRECATED'
   declarator __attribute__((deprecated(message)))
   ^
../src/unix/pty.cc: In function 'void pty_after_waitpid(uv_async_t*)':
../src/unix/pty.cc:495:69: warning: 'v8::Local<v8::Value> Nan::Callback::Call(v8::Local<v8::Object>, int, v8::Local<v8::Value>*) const' is deprecated (declared at ../../nan/nan.h:1718) [-Wdeprecated-declarations]
   Nan::Callback(cb).Call(Nan::GetCurrentContext()->Global(), 2, argv);
                                                                     ^
make: *** [Release/obj.target/pty/src/unix/pty.o] Error 1
make: Leaving directory `/__w/1/s/node_modules/node-pty/build'

(https://monacotools.visualstudio.com/DefaultCollection/Monaco/_build/results?buildId=51890)

@deepak1556
Copy link
Contributor

deepak1556 commented Jul 8, 2019 •
edited
Loading

microsoft/vscode@5d94f7a#diff-8ee2343978836a779dc9f8d6b794c3b2R6058 its currently locking to last stable release.

should probably do yarn upgrade node-pty@beta

@Tyriar
Copy link
Member

Tyriar commented Jul 8, 2019

Weird, what happened there 😕

Screen Shot 2019-07-08 at 7 38 45 AM

@Tyriar Tyriar mentioned this issue Jul 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepak1556 deepak1556

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

fix: node 12 build errors for windows microsoft/node-pty
3 participants
@bpasero @deepak1556 @Tyriar