Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Fix trainingService initialize error in View mode #3872

Merged
merged 44 commits into from
Jun 25, 2021
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
dcd2ffd
Merge pull request #251 from microsoft/master
SparkSnail May 29, 2020
3b8b6fb
Merge pull request #252 from microsoft/master
SparkSnail Jun 7, 2020
916e444
Merge pull request #253 from microsoft/master
SparkSnail Jun 15, 2020
caeffb8
Merge pull request #254 from microsoft/master
SparkSnail Jun 17, 2020
57c300e
Merge pull request #255 from microsoft/master
SparkSnail Jun 28, 2020
65660e6
Merge pull request #257 from microsoft/master
SparkSnail Jun 30, 2020
9376d6a
Merge pull request #258 from microsoft/master
SparkSnail Jul 1, 2020
5fef3cf
Merge pull request #259 from microsoft/master
SparkSnail Jul 3, 2020
5544ae8
Merge pull request #261 from microsoft/master
SparkSnail Jul 10, 2020
f9fdfee
Merge pull request #262 from microsoft/master
SparkSnail Jul 16, 2020
aa64fe6
Merge pull request #263 from microsoft/master
SparkSnail Jul 27, 2020
c6a5f8c
Merge pull request #264 from microsoft/master
SparkSnail Jul 31, 2020
68abe2f
Merge pull request #265 from microsoft/master
SparkSnail Aug 4, 2020
14e9619
Merge pull request #266 from microsoft/master
SparkSnail Aug 13, 2020
f69e206
Merge pull request #267 from microsoft/master
SparkSnail Aug 13, 2020
12ef0aa
Merge pull request #270 from microsoft/master
SparkSnail Sep 10, 2020
ddcf229
Merge pull request #271 from microsoft/master
SparkSnail Sep 15, 2020
c4f6e66
Merge pull request #272 from microsoft/master
SparkSnail Sep 21, 2020
88f8c1b
Merge pull request #273 from microsoft/master
SparkSnail Sep 22, 2020
7eb15f8
Merge pull request #274 from microsoft/master
SparkSnail Oct 27, 2020
f73367f
Merge pull request #275 from microsoft/master
SparkSnail Nov 16, 2020
765bc33
Merge pull request #276 from microsoft/master
SparkSnail Nov 29, 2020
cff51cc
Merge pull request #277 from microsoft/master
SparkSnail Dec 2, 2020
4232fea
Merge pull request #278 from microsoft/master
SparkSnail Dec 8, 2020
cb9efcc
Merge pull request #279 from microsoft/master
SparkSnail Dec 11, 2020
ee71f16
Merge pull request #280 from microsoft/master
SparkSnail Dec 14, 2020
c3921ed
Merge pull request #281 from microsoft/master
SparkSnail Dec 24, 2020
561f1ad
Merge pull request #284 from microsoft/master
SparkSnail Jan 22, 2021
daf028a
Merge pull request #285 from microsoft/master
SparkSnail Feb 5, 2021
9a8a4a3
Merge pull request #286 from microsoft/master
SparkSnail Feb 8, 2021
22a38dd
Merge pull request #287 from microsoft/master
SparkSnail Feb 23, 2021
645e1a6
Merge pull request #288 from microsoft/master
SparkSnail Feb 24, 2021
f41c25d
Merge pull request #289 from microsoft/master
SparkSnail Feb 25, 2021
9fb5ff9
Merge pull request #290 from microsoft/master
SparkSnail Mar 4, 2021
e3fab14
Merge pull request #291 from microsoft/master
SparkSnail Mar 23, 2021
ad26f40
Merge pull request #292 from microsoft/master
SparkSnail Apr 12, 2021
ad78613
Merge pull request #294 from microsoft/master
SparkSnail Apr 30, 2021
5453841
Merge pull request #295 from microsoft/master
SparkSnail May 7, 2021
09f977e
Merge pull request #296 from microsoft/master
SparkSnail May 19, 2021
fdb2d77
set version check as warning
SparkSnail May 19, 2021
5190f5a
Merge pull request #297 from microsoft/master
SparkSnail May 24, 2021
805e773
Merge pull request #298 from microsoft/master
SparkSnail May 26, 2021
f9dbdb4
Merge pull request #299 from microsoft/master
SparkSnail Jun 23, 2021
26eefdf
init
SparkSnail Jun 24, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ts/nni_manager/core/nnimanager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -204,11 +204,6 @@ class NNIManager implements Manager {
const experimentId: string = getExperimentId();
this.log.info(`Resuming experiment: ${experimentId}`);
this.experimentProfile = await this.dataStore.getExperimentProfile(experimentId);
this.readonly = readonly;
if (readonly) {
this.setStatus('VIEWED');
return Promise.resolve();
}

const config: ExperimentConfig = this.experimentProfile.params;
this.config = config;
Expand All @@ -217,6 +212,12 @@ class NNIManager implements Manager {
this.trainingService = await this.initTrainingService(config);
}

this.readonly = readonly;
if (readonly) {
this.setStatus('VIEWED');
return;
}

this.log.info('Setup tuner...');
const dispatcherCommand: string = getMsgDispatcherCommand(config);
this.log.debug(`dispatcher command: ${dispatcherCommand}`);
Expand Down