Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

fix bugs on second bug bash #3016

Merged
merged 1 commit into from
Oct 22, 2020
Merged

fix bugs on second bug bash #3016

merged 1 commit into from
Oct 22, 2020

Conversation

Lijiaoa
Copy link
Contributor

@Lijiaoa Lijiaoa commented Oct 21, 2020 •
edited
Loading

fix issue:

  1. table column width
    image
  2. command padding
    image
  3. duration unit
    image
  4. button style
    image
  5. modifiy css to fix Trial jobs style
    image

SparkSnail
SparkSnail reviewed Oct 21, 2020
View reviewed changes
src/webui/src/components/trial-detail/TableList.tsx
columns.push({
name: columnTitle,
key: k,
fieldName: k,
minWidth: columnWidth * 13,
maxWidth: columnWidth * 18,
minWidth: widths * 0.12,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to get the pixel value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(window.innerWidth * 0.85 - (20px expand button) - (150px operation)) / (5列) 来拿到每一列的宽度，宽度/屏幕宽拿到比列系数，各个屏幕适配得到最优比~

@QuanluZhang QuanluZhang merged commit 1152094 into microsoft:v1.9 Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ultmaster ultmaster ultmaster approved these changes

@SparkSnail SparkSnail SparkSnail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lijiaoa @ultmaster @SparkSnail @QuanluZhang