Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cudnn.deterministic been set while import, suggestion to avoid this kind of behavior #4117

Closed
mstczuo opened this issue Aug 27, 2021 · 3 comments
Closed

cudnn.deterministic been set while import, suggestion to avoid this kind of behavior #4117

mstczuo opened this issue Aug 27, 2021 · 3 comments
Assignees
@J-shang
Labels
external contributor

Comments

@mstczuo
Copy link
Contributor

mstczuo commented Aug 27, 2021

nni/nni/algorithms/compression/pytorch/pruning/amc/amc_pruner.py

Line 17 in e85f029

torch.backends.cudnn.deterministic = True

This line of code executes when someone just import nni.algorithms.compression.pytorch.pruning, I suggest to move it into the constructor function of AMCPruner and reset cudnn.deterministic after training because it changed an import setting but does not tell the user.
@mstczuo mstczuo changed the title cudnn.deterministic being set while import, suggestion to avoid this kind of behavior cudnn.deterministic been set while import, suggestion to avoid this kind of behavior Aug 27, 2021
@scarlett2018
Copy link
Member

@mstczuo - would you like to submit a PR for the suggestion? thanks.

@mstczuo mstczuo mentioned this issue Sep 1, 2021
Closed
@mstczuo
Copy link
Contributor Author

mstczuo commented Sep 1, 2021

@mstczuo - would you like to submit a PR for the suggestion? thanks.

sure. I have submitted this PR: #4139

@mstczuo
Copy link
Contributor Author

mstczuo commented Sep 8, 2021

PR #4161 solved this issue.

@mstczuo mstczuo closed this as completed Sep 8, 2021
@liuzhe-lz liuzhe-lz mentioned this issue Oct 29, 2021
Closed
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@J-shang J-shang

Labels
external contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update amc_pruner.py mstczuo/nni
3 participants
@mstczuo @J-shang @scarlett2018