Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL: Update the git workflow so that upon release we won't need to manually rename 12 files #216

Open
forwardpointer opened this issue Apr 6, 2023 · 0 comments

Comments

@forwardpointer
Copy link
Contributor

forwardpointer commented Apr 6, 2023

Words from Andrew:
"""
the idea is that the cmake install command prepares an output tree with stuff that is interesting from our project. That has a few dirs like bin for binaries, include for headers, and I think lib for libraries. CPack goes and collects that stuff and packages it up, and is supposed to be fairly configurable in that you can use CMAKE_* variables in the file names.

In practice, it never worked properly for me.

There is also a weird dance of variable sharing between CMake and CPack, because certain things are set at configure-time, and other thigns aren't available until build-time, especially with "multi-config" generators, like the Visual Studio generator and Ninja Multi-build (both of which we use). We have no chocie for the Visual Studio one; we could change to single-config Ninja for Linux, but that would complicate things even further since we'd have to have separate CPack configs per OS

I'd eventually like to get back to it, but renaming the files manually was the least of all evils at the time, so I stuck with that after having been super frustrated and burned WAY more time than I ever wanted to on something that's not even related to the feature/code
"""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant