Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teaching tip narrator announcement does not announce the subtitle #3277

Closed
nilaysanghvi opened this issue Sep 11, 2020 · 3 comments
Closed
Labels
accessibility Narrator, keyboarding, UIA, etc area-TeachingTip team-Controls Issue for the Controls team

Comments

@nilaysanghvi
Copy link

The current narrator announcement is - "Press F6 to go to new notification from [App name]. [Teaching tip Title]".
Ideally, the subtitle should be announced too, and if not then at least the developer should be given the option to control if the subtitle should be announced or not.

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Sep 11, 2020
@StephenLPeters
Copy link
Contributor

I'm not sure that I agree that the subtitle should always be read along with the teaching tip title. However you should be able to adjust what narrator reads by setting automation properties on your TeachingTip. Setting AutomationID of the tip eventually gets folded into the announcement from narrator here:

return StringUtil::FormatString(
. It is possible we should be folding more automation properties into this announcement, but does this point of customization fulfill your needs?

@StephenLPeters StephenLPeters added accessibility Narrator, keyboarding, UIA, etc area-TeachingTip needs-author-feedback Asked author to supply more information. team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Sep 14, 2020
@ghost ghost added the no-recent-activity label Sep 22, 2020
@ghost
Copy link

ghost commented Sep 22, 2020

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@nilaysanghvi
Copy link
Author

@StephenLPeters Yes it does. Thanks a lot!

@ghost ghost added needs-triage Issue needs to be triaged by the area owners and removed needs-author-feedback Asked author to supply more information. no-recent-activity labels Sep 25, 2020
@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Narrator, keyboarding, UIA, etc area-TeachingTip team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

3 participants