Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Hyperdrive jobs not possible with v2 SDK #880

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

BUG: Hyperdrive jobs not possible with v2 SDK #880

wants to merge 9 commits into from

Conversation

ant0nsc
Copy link
Collaborator

@ant0nsc ant0nsc commented May 3, 2023

No description provided.

@ant0nsc ant0nsc linked an issue May 3, 2023 that may be closed by this pull request
Hyperdrive jobs can't be submitted with SDK v2 #870
Open
@codecov
Copy link

codecov bot commented May 3, 2023 •
edited

Codecov Report

Merging #880 (6d36fa7) into main (7e8c8a0) will increase coverage by 0.02%.
The diff coverage is 75.38%.

Impacted file tree graph

Flag Coverage Δ
hi-ml 82.89% <76.56%> (-0.13%) ⬇️
hi-ml-azure 25.37% <0.00%> (-0.02%) ⬇️
hi-ml-cpath 75.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hi-ml-azure/src/health_azure/himl.py 26.93% <0.00%> (-0.09%) ⬇️
hi-ml/src/health_ml/experiment_config.py 100.00% <ø> (ø)
hi-ml/src/health_ml/configs/hello_world.py 83.45% <41.66%> (-3.95%) ⬇️
hi-ml/src/health_ml/utils/common_utils.py 84.89% <83.33%> (-0.98%) ⬇️
hi-ml/src/health_ml/deep_learning_config.py 84.58% <100.00%> (+0.06%) ⬆️
hi-ml/src/health_ml/runner.py 87.64% <100.00%> (+0.75%) ⬆️

@fepegar
Copy link
Contributor

fepegar commented May 13, 2024

In case it helps, this has been driving me a bit crazy today as well. I've found from older runs of mine that the shared memory is correctly taken into account when downgrading to azure-ai-ml==1.5.0. I was trying 1.15.0 so I think that feature was broken somewhere in between.

@fepegar fepegar mentioned this pull request May 13, 2024
Open
@fepegar
Copy link
Contributor

fepegar commented May 14, 2024

In case it helps, this has been driving me a bit crazy today as well. I've found from older runs of mine that the shared memory is correctly taken into account when downgrading to azure-ai-ml==1.5.0. I was trying 1.15.0 so I think that feature was broken somewhere in between.

I've run some tests. This is broken for azure-ai-ml>=1.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hyperdrive jobs can't be submitted with SDK v2
2 participants
@ant0nsc @fepegar