Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Document command inserts unnecessary null values into the docker-compose.yml file #65

Closed
azuregos opened this issue Nov 19, 2021 · 1 comment · Fixed by #67
Closed
Labels
bug Something isn't working

Comments

@azuregos
Copy link

There is an issue when calling 'Format Document' on a Docker compose file in Docker plugin v1.18.0
When called additional null values are added to the file.

Reproduction Scenario

  1. Create docker-compose.yml file with the following content
version: "3"
services:

  service:
    image: service

networks:
  a-net:
  b-net:

volumes:
  a-data:
  b-data:
  c-data:
  d-data:
  1. In VsCode invoke a 'Format Document' command
  2. Note the added null values to the file:
version: "3"
services:

  service:
    image: service

networks:
  a-net: null
  b-net:

    null
volumes:
  a-data: null
  b-data: null
  c-data: null
  d-data: null

VsCode Version

Version: 1.62.3 (system setup)
Commit: ccbaa2d27e38e5afa3e5c21c1c7bef4657064247
Date: 2021-11-17T08:11:14.551Z
Electron: 13.5.2
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19042
@bwateratmsft
Copy link
Contributor

Thanks @azuregos, I'll transfer this to the compose language service' repo.

@bwateratmsft bwateratmsft transferred this issue from microsoft/vscode-docker Nov 19, 2021
@bwateratmsft bwateratmsft added the bug Something isn't working label Nov 30, 2021
@microsoft microsoft locked and limited conversation to collaborators Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants