-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forgotten 'await' error doesn't account for strictPropertyInitialization #43071
Comments
Conclusion:
|
The design meeting notes say
which seems to conflict with
Unless I’m misunderstanding something? |
Yeah, seems confusing - I think that might've been a rushed conclusion that overlooked the existing discussion. |
We recently ran into some breaks in #43004 (comment) as a result of #25330; however, I think this might be a bigger change than we anticipate.
For one, we don't check whether the value is used after checking the value. For another, we don't really think about class properties, which aren't reliable unless using
strictPropertyInitialization
.Finally, there's some sort of bug where this is plainly giving false positives.
I guess the question is: should these be errors?
The text was updated successfully, but these errors were encountered: