Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSServer Crashes when Opening file from Mapped Sharepoint Drive #13997

Closed
mjbvz opened this issue Feb 10, 2017 · 4 comments · Fixed by #14098
Closed

TSServer Crashes when Opening file from Mapped Sharepoint Drive #13997

mjbvz opened this issue Feb 10, 2017 · 4 comments · Fixed by #14098
Labels
Fixed A PR has been merged for this issue High Priority VS Code Tracked There is a VS Code equivalent to this issue

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Feb 10, 2017

From: microsoft/vscode#20445

TypeScript Version: 2.1.6

This issue is similar to #13874 but when opening a mapped sharepoint drive on windows instead of opening the WebDAV drive directly.

Repo Steps

  • In windows, mount a sharepoint WebDAV drive by going to This PC -> map network drive.
  • Open a file on this drive in VSCode. For example: Z:\Java and Open Tools\Node\test

This produces the same symptoms as #13874

[Info  - 11:32:02 AM] Using tsserver from location: c:\Program Files (x86)\Microsoft VS Code\resources\app\extensions\typescript\node_modules\typescript\lib\tsserver.js
[Trace - 11:32:02 AM] Sending request: configure (33). Response expected: yes. Current queue length: 0
Arguments: {
    "hostInfo": "vscode"
}
[Trace - 11:32:03 AM] Response received: configure (33). Request took 467 ms. Success: true 
[Trace - 11:32:03 AM] Sending request: compilerOptionsForInferredProjects (34). Response expected: yes. Current queue length: 3
Arguments: {
    "options": {
        "module": "CommonJS",
        "target": "ES6",
        "allowSyntheticDefaultImports": true,
        "allowNonTsExtensions": true,
        "allowJs": true,
        "jsx": "Preserve"
    }
}
[Trace - 11:32:03 AM] Response received: compilerOptionsForInferredProjects (34). Request took 483 ms. Success: true 
Result: true
[Trace - 11:32:03 AM] Sending request: open (35). Response expected: no. Current queue length: 2
Arguments: {
    "file": "z:/Java and Open Tools/Node/test/main.js",
    "fileContent": "console.log()\r\nfdsaf gdsczx"
}
[Trace - 11:32:03 AM] Sending request: geterr (36). Response expected: no. Current queue length: 1
Arguments: {
    "delay": 0,
    "files": []
}
[Trace - 11:32:03 AM] Sending request: geterr (37). Response expected: no. Current queue length: 0
Arguments: {
    "delay": 0,
    "files": [
        "z:/Java and Open Tools/Node/test/main.js"
    ]
}
[Error - 11:32:03 AM] TSServer exited with code: 3221226356
@kieferrm
Copy link
Member

@mhegazy an update?

@mhegazy
Copy link
Contributor

mhegazy commented Feb 15, 2017

Not sure there is an easy fix here. Node crashes. the options we have are either:

  • have a new process to probe if watching is possible.
  • have VSCode tell us what directories is safe to watch.
  • disable watching for all folders mapped to network share.

I should add, this issue is not new. it has been there for a very long time. I would be interested to understand why it has not come up before.

@mjbvz
Copy link
Contributor Author

mjbvz commented Feb 15, 2017

There is probably a better way to do this, but on windows would the net use command work? This would let us understand if target drive is a mapped network drive. For example:

> net use z:
Local name        z:
Remote name       \\microsoft.sharepoint.com@SSL\DavWWWRoot\teams\DD_OTP\Documents\Java and Open Tools
Resource type     Disk
The command completed successfully.

@semmy2010
Copy link

semmy2010 commented Feb 16, 2017

@mjbvz As soon as I opened the *.ts of TypeScript file, it reported the error. I did not mapped the virtual disk.

@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Feb 16, 2017
@mhegazy mhegazy added this to the TypeScript 2.2.1 milestone Feb 16, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Fixed A PR has been merged for this issue High Priority VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants