Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change Fabric Cog Service Token to Support Billing #2291

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

lhrotk
Copy link
Contributor

@lhrotk lhrotk commented Sep 27, 2024

What changes are proposed in this pull request?

For both openai and cognitive transformers, need shift to use another MWC Token issued by spark core workload in Fabric which contains billing info.
The old mwc token will get rejected soon.

How is this patch tested?

Manually tested in Fabric

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.

@lhrotk
Copy link
Contributor Author

lhrotk commented Sep 27, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 84.52%. Comparing base (6854b5f) to head (ec12ada).

Files with missing lines Patch % Lines
...crosoft/azure/synapse/ml/fabric/TokenLibrary.scala 0.00% 16 Missing ⚠️
...crosoft/azure/synapse/ml/fabric/FabricClient.scala 0.00% 3 Missing ⚠️
...ure/synapse/ml/services/CognitiveServiceBase.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2291      +/-   ##
==========================================
+ Coverage   83.70%   84.52%   +0.82%     
==========================================
  Files         327      326       -1     
  Lines       16788    16769      -19     
  Branches     1500     1502       +2     
==========================================
+ Hits        14052    14174     +122     
+ Misses       2736     2595     -141     
Flag Coverage Δ
82.21% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lhrotk
Copy link
Contributor Author

lhrotk commented Oct 7, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lhrotk lhrotk changed the title [WIP] Change Fabric Cog Service Token to Support Billing feat: Change Fabric Cog Service Token to Support Billing Oct 8, 2024
@mhamilton723 mhamilton723 merged commit 8e1c6f8 into microsoft:master Oct 10, 2024
67 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants