Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] fixed links and typos #855

Merged
merged 4 commits into from
Aug 22, 2017
Merged

[docs] fixed links and typos #855

merged 4 commits into from
Aug 22, 2017

Conversation

StrikerRUS
Copy link
Collaborator

No description provided.

@msftclas
Copy link

@StrikerRUS,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

guolinke
guolinke reviewed Aug 22, 2017
View reviewed changes
docs/FAQ.md Outdated
@@ -82,7 +82,7 @@ Remember this is a free/open community support. We may not be available 24/7 to

- **Question 8**: CPU are not kept busy (like 10% CPU usage only) in Windows when using LightGBM on very large datasets with many core systems.

- **Solution 8**: Please use [use Visual Studio](https://github.com/Microsoft/LightGBM/issues/740) as it may be 10x faster than MinGW especially for very large trees.
- **Solution 8**: Please [use Visual Studio](https://github.com/Microsoft/LightGBM/issues/740) as it may be 10x faster than MinGW especially for very large trees.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use [Visual Studio] ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other links with brand names in docs leads to third party sites, but this one refers to GitHub issue. So, I suppose, this will be confusing for users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Visual Studio" should point out to Visual Studio, not the GitHub issue.

A user must not expect to land on GitHub when clicking on "use Visual Studio" (the user supposes they get a link to Visual Studio).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, just change link to VS homepage?

Copy link
Contributor

@Laurae2 Laurae2 Aug 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, just change link to VS homepage?

Link to Visual Studio homepage download

And add a link to the GitHub issue, for instance on "10x faster than MinGW".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sure.

Copy link
Collaborator Author

@StrikerRUS StrikerRUS Aug 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Laurae2 Is existing reference to GitHub issue right? It leads to small python-package PR.
UPD: I suppose this one is right: #749

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use this issue: #749

@guolinke guolinke merged commit 49412ba into microsoft:master Aug 22, 2017
@StrikerRUS StrikerRUS deleted the docs branch August 22, 2017 14:35
guolinke pushed a commit that referenced this pull request Oct 9, 2017
@StrikerRUS @guolinke
[docs] fixed links and typos (#855)
16cf7f0 
* fixed links while viewing from wiki page

* fixed typos

* fixed repeated word and added markdown in FAQ.md

* fixed link to VS
@lock lock bot locked as resolved and limited conversation to collaborators Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Laurae2 Laurae2 Laurae2 left review comments

@guolinke guolinke guolinke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StrikerRUS @msftclas @Laurae2 @guolinke