[R-package] remove unnecessary comments and fix typos in comments #4902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
reviewed
Dec 22, 2021
| @@ -550,7 +550,7 @@ lgb.stratified.folds <- function(y, k) { | |||
|
|
|||
| ## Create a vector of integers from 1:k as many times as possible without | |||
| ## going over the number of samples in the class. Note that if the number | |||
| ## of samples in a class is less than k, nothing is producd here. | |||
| ## of samples in a class is less than k, nothing is produced here. | |||
There was a problem hiding this comment.
Just out of my curiosity, why double ## here?
There was a problem hiding this comment.
no reason at all! According to the git blame, these lines were added 5 years ago
I'd support a PR changing them (and other instances like this) to a single #
StrikerRUS
approved these changes
Dec 22, 2021
This was referenced Jan 6, 2022
40 tasks
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been looking more closely at the R package recently, and noticed a few comments that are either uninformative or provide typos. This PR proposes cleaning them up.