[python-package] fix mypy errors in sklearn.py #4837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
requested review from
chivee,
henry0312,
hzy46,
shiyu1994,
StrikerRUS and
tongwu-sh
as code owners
jameslamb
commented
Nov 30, 2021
| @@ -1008,7 +1008,7 @@ def fit(self, X, y, | |||
| callbacks=callbacks, init_model=init_model) | |||
| return self | |||
|
|
|||
| _base_doc = LGBMModel.fit.__doc__.replace("self : LGBMModel", "self : LGBMClassifier") | |||
| _base_doc = LGBMModel.fit.__doc__.replace("self : LGBMModel", "self : LGBMClassifier") # type: ignore | |||
There was a problem hiding this comment.
warnings about .__doc__ being Optional[str] could be avoided by changing this to something like getattr(LGBMModel.fit, "__doc__", ""), but I think this is preferable, so that .replace() raises an exception in CI if something is accidentally changed that results in the docs being empty for a method.
StrikerRUS
requested changes
Dec 1, 2021
StrikerRUS
reviewed
Dec 1, 2021
13 tasks
40 tasks
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3867.
This PR fixes
mypyerrors insklearn.py.Confirmed that this suppresses these warnings by running the following.
mypy \ --exclude='python-package/compile/|python-package/build' \ --ignore-missing-imports \ python-package/