Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix getting status of optional workflows in PRs with a lot of comments #4806

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Refer to https://docs.github.com/en/rest/reference/issues#list-issue-comments.

In #3234 (comment) script cannot update status for Solaris CI build because it doesn't receive the latest comments in that PR.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha WOW, I never imagined we'd have a PR with so many comments that it would require pagination over GitHub API results 😂

thanks for investigating this

@StrikerRUS StrikerRUS marked this pull request as ready for review November 17, 2021 00:29
@shiyu1994
Copy link
Collaborator

shiyu1994 commented Nov 17, 2021

Thank you for this. Sorry about the long PR which causes inconvenience.

@jameslamb
Copy link
Collaborator

Sorry about the long PR which causes inconvenience.

Don't worry at all! Sorry, I was not complaining. I appreciate you patiently keeping it open all this time until we were ready to start on 4.0.

I've also been the author of PRs with a lot of comments 😄

@jameslamb jameslamb self-requested a review November 17, 2021 02:14
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, thanks!

@shiyu1994 shiyu1994 merged commit 06e3c4a into master Nov 17, 2021
@jameslamb jameslamb deleted the fix_chatops branch November 17, 2021 03:56
@StrikerRUS
Copy link
Collaborator Author

That was totally my fault in poor design of comments retrieving routine. Of course, it should has worked for any size PRs from the beginning. I'm sorry about that!

@shiyu1994
Copy link
Collaborator

That was totally my fault in poor design of comments retrieving routine. Of course, it should has worked for any size PRs from the beginning. I'm sorry about that!

Many thanks to you for supporting the ci tests. You've done very well!

@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants