Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] indicate support of Monterey #4732

Merged
merged 3 commits into from
Oct 30, 2021
Merged

[ci] indicate support of Monterey #4732

merged 3 commits into from
Oct 30, 2021

Conversation

StrikerRUS
Copy link
Collaborator

According to the policy, we indicate support only for the last 3 macOS versions in wheel name: #2691 (comment).

I believe that "the last 3 macOS versions" means 3 last major releases like it was before 11.x

Successfully built bottles for arm64_monterey, arm64_big_sur, monterey, big_sur, catalina, mojave by Homebrew team give some confidence in that LightGBM is indeed compatible with the wide range of macOS versions.
https://github.com/Homebrew/homebrew-core/blob/4060c0ab42d8b9b7168b34f55f12e16a91b27150/Formula/lightgbm.rb#L10-L15

Just FYI, it is now possible to provide one universal2 wheel for both x86_64 and arm64.

@StrikerRUS StrikerRUS changed the title [ci] indicate support of Monterey and drop Catalina [ci] indicate support of Monterey and drop Mojave Oct 28, 2021
@StrikerRUS
Copy link
Collaborator Author

CI is failing with

ERROR: lightgbm-3.3.1-py3-none-macosx_10_15_x86_64.macosx_11_6_x86_64.macosx_12_0_x86_64.whl is not a supported wheel on this platform.

This is because Mojave is used at our macOS CI worker:

Operating System
Mac OS X
10.14.6
18G9323

I suggest to keep Mojave support for now then.

@StrikerRUS StrikerRUS changed the title [ci] indicate support of Monterey and drop Mojave [ci] indicate support of Monterey Oct 28, 2021
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I agree with your interpretation of "last 3 major versions".

@jameslamb jameslamb merged commit dcae8dd into master Oct 30, 2021
@jameslamb jameslamb deleted the macos_wheel_name branch October 30, 2021 04:59
@StrikerRUS
Copy link
Collaborator Author

I agree with your interpretation of "last 3 major versions".

Just to clarify, right now due to the restrictions of our CI (#4732 (comment)) we are supporting "last 4 major versions", not 3.

We may consider migrating to a newer macOS builder like XGBoost recently did: dmlc/xgboost#7382.
But it will require updating info about the Xcode version used to create release artifacts in two places
https://github.com/microsoft/LightGBM/tree/master/python-package#install-from-pypi

sudo xcode-select -s /Applications/Xcode_9.4.1.app/Contents/Developer || exit -1

because the minimum available version of Xcode at macos-10.15 builder is 10.3
https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md#xcode

And I don't know whether new artifacts will remain backward compatible.

@jameslamb
Copy link
Collaborator

Got it, yep thanks for the further explanation. Makes sense to me.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants