Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Change some 'parallel learning' references to 'distributed learning' #4000

Merged
merged 4 commits into from
Feb 19, 2021

Conversation

jameslamb
Copy link
Collaborator

In #3596, we agreed to replace the terminology "parallel learning" with "distributed learning" in this project's documentation, everywhere that that phrase was used to refer to multi-machine training. It was also agreed in that issue that this change should not break any current documentation links.

I've started doing that in #3951, in preparation for adding new Dask docs (#3814).

While working on #3951, I realized that many of the places where this language needs to be changed won't break any links. These are in things like code comments and log messages.

This pull request proposes just those changes that don't break links, to hopefully reduce the size of #3951 and make it easier to review.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Just one comment.

@@ -21,14 +21,14 @@ LightGBM is a gradient boosting framework that uses tree based learning algorith
- Faster training speed and higher efficiency.
- Lower memory usage.
- Better accuracy.
- Support of parallel and GPU learning.
- Support of parallel, distributed, and GPU learning.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah missed that one, thanks. Added in 7985222

@jameslamb jameslamb merged commit 7880b79 into master Feb 19, 2021
@jameslamb jameslamb deleted the misc/distributed-learning branch February 19, 2021 15:47
jameslamb added a commit that referenced this pull request Feb 22, 2021
…3951)

* rework distributed learning page

* more references

* more changes

* more changes

* add anchors for olds links

* revert changes from #4000

* fix links

* more links

* Apply suggestions from code review

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update docs/Parallel-Learning-Guide.rst

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants