Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compilation warnings in CUDA treelearner #3889

Merged
merged 4 commits into from
Feb 9, 2021
Merged

fix compilation warnings in CUDA treelearner #3889

merged 4 commits into from
Feb 9, 2021

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented Feb 1, 2021 •
edited
Loading

Only Clang catches these warnings, gcc keeps silent.

2021-01-31T19:13:39.6160069Z -- The C compiler identification is Clang 10.0.0
2021-01-31T19:13:39.8645777Z -- The CXX compiler identification is Clang 10.0.0
2021-01-31T19:13:39.8708248Z -- Detecting C compiler ABI info
2021-01-31T19:13:39.9494377Z -- Detecting C compiler ABI info - done
2021-01-31T19:13:39.9565736Z -- Check for working C compiler: /usr/bin/clang - skipped
2021-01-31T19:13:39.9567925Z -- Detecting C compile features
2021-01-31T19:13:39.9571685Z -- Detecting C compile features - done
2021-01-31T19:13:39.9606907Z -- Detecting CXX compiler ABI info
2021-01-31T19:13:40.0748046Z -- Detecting CXX compiler ABI info - done
2021-01-31T19:13:40.0822343Z -- Check for working CXX compiler: /usr/bin/clang++ - skipped
2021-01-31T19:13:40.0824720Z -- Detecting CXX compile features
2021-01-31T19:13:40.0829713Z -- Detecting CXX compile features - done
2021-01-31T19:13:40.7894269Z -- The CUDA compiler identification is NVIDIA 11.2.67
2021-01-31T19:13:40.7952408Z -- Detecting CUDA compiler ABI info
2021-01-31T19:13:41.4666986Z -- Detecting CUDA compiler ABI info - done
2021-01-31T19:13:41.4859838Z -- Check for working CUDA compiler: /usr/local/cuda/bin/nvcc - skipped
2021-01-31T19:13:41.4862381Z -- Detecting CUDA compile features
2021-01-31T19:13:41.4866910Z -- Detecting CUDA compile features - done
2021-01-31T19:13:41.8045401Z -- Found OpenMP_C: -fopenmp=libomp (found version "4.5") 
2021-01-31T19:13:41.9291462Z -- Found OpenMP_CXX: -fopenmp=libomp (found version "4.5") 
2021-01-31T19:13:41.9293150Z -- Found OpenMP: TRUE (found version "4.5")  
2021-01-31T19:13:41.9352458Z -- Looking for pthread.h
2021-01-31T19:13:42.0168611Z -- Looking for pthread.h - found
2021-01-31T19:13:42.0169752Z -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
2021-01-31T19:13:42.0974765Z -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
2021-01-31T19:13:42.0975554Z -- Looking for pthread_create in pthreads
2021-01-31T19:13:42.1613103Z -- Looking for pthread_create in pthreads - not found
2021-01-31T19:13:42.1613936Z -- Looking for pthread_create in pthread
2021-01-31T19:13:42.2373966Z -- Looking for pthread_create in pthread - found
2021-01-31T19:13:42.2385696Z -- Found Threads: TRUE  
2021-01-31T19:13:42.2448451Z -- Found CUDA: /usr/local/cuda (found version "11.2") 
2021-01-31T19:13:42.2459987Z -- CMAKE_CUDA_FLAGS: -Xcompiler=-fopenmp=libomp -Xcompiler=-fPIC -Xcompiler=-Wall -gencode arch=compute_60,code=sm_60 -gencode arch=compute_61,code=sm_61 -gencode arch=compute_62,code=sm_62 -gencode arch=compute_70,code=sm_70 -gencode arch=compute_75,code=sm_75 -gencode arch=compute_75,code=compute_75 -O3 -lineinfo
2021-01-31T19:13:42.2461852Z -- ALLFEATS_DEFINES: -DPOWER_FEATURE_WORKGROUPS=12;-DUSE_CONSTANT_BUF=0;-DENABLE_ALL_FEATURES
2021-01-31T19:13:42.2462911Z -- FULLDATA_DEFINES: -DPOWER_FEATURE_WORKGROUPS=12;-DUSE_CONSTANT_BUF=0;-DENABLE_ALL_FEATURES;-DIGNORE_INDICES
2021-01-31T19:13:42.2469917Z -- Performing Test MM_PREFETCH
2021-01-31T19:13:42.3988686Z -- Performing Test MM_PREFETCH - Success
2021-01-31T19:13:42.3989370Z -- Using _mm_prefetch
2021-01-31T19:13:42.3991352Z -- Performing Test MM_MALLOC
2021-01-31T19:13:42.5197306Z -- Performing Test MM_MALLOC - Success
2021-01-31T19:13:42.5198008Z -- Using _mm_malloc
2021-01-31T19:13:42.5208158Z -- Configuring done
2021-01-31T19:13:42.5241475Z                                                                                          
2021-01-31T19:13:42.5241985Z CMake Warning (dev) in CMakeLists.txt:
2021-01-31T19:13:42.5242602Z   Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
2021-01-31T19:13:42.5243669Z   empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
2021-01-31T19:13:42.5244397Z   for policy details.  Use the cmake_policy command to set the policy and
2021-01-31T19:13:42.5244898Z   suppress this warning.
2021-01-31T19:13:42.5245146Z 
2021-01-31T19:13:42.5245552Z   CUDA_ARCHITECTURES is empty for target "histo_16_64_256_sp_const".
2021-01-31T19:13:42.5246380Z This warning is for project developers.  Use -Wno-dev to suppress it.
2021-01-31T19:13:42.5246770Z 
2021-01-31T19:13:42.5255157Z CMake Warning (dev) in CMakeLists.txt:
2021-01-31T19:13:42.5255754Z   Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
2021-01-31T19:13:42.5256738Z   empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
2021-01-31T19:13:42.5257414Z   for policy details.  Use the cmake_policy command to set the policy and
2021-01-31T19:13:42.5257926Z   suppress this warning.
2021-01-31T19:13:42.5258176Z 
2021-01-31T19:13:42.5258562Z   CUDA_ARCHITECTURES is empty for target "histo_16_64_256_sp".
2021-01-31T19:13:42.5259352Z This warning is for project developers.  Use -Wno-dev to suppress it.
2021-01-31T19:13:42.5259745Z 
2021-01-31T19:13:42.5268696Z CMake Warning (dev) in CMakeLists.txt:
2021-01-31T19:13:42.5269288Z   Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
2021-01-31T19:13:42.5270270Z   empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
2021-01-31T19:13:42.5270964Z   for policy details.  Use the cmake_policy command to set the policy and
2021-01-31T19:13:42.5271478Z   suppress this warning.
2021-01-31T19:13:42.5271706Z 
2021-01-31T19:13:42.5272351Z   CUDA_ARCHITECTURES is empty for target "histo_16_64_256-allfeats_sp_const".
2021-01-31T19:13:42.5273172Z This warning is for project developers.  Use -Wno-dev to suppress it.
2021-01-31T19:13:42.5273566Z 
2021-01-31T19:13:42.5282341Z CMake Warning (dev) in CMakeLists.txt:
2021-01-31T19:13:42.5282963Z   Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
2021-01-31T19:13:42.5284143Z   empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
2021-01-31T19:13:42.5284861Z   for policy details.  Use the cmake_policy command to set the policy and
2021-01-31T19:13:42.5285358Z   suppress this warning.
2021-01-31T19:13:42.5285606Z 
2021-01-31T19:13:42.5286252Z   CUDA_ARCHITECTURES is empty for target "histo_16_64_256-allfeats_sp".
2021-01-31T19:13:42.5287074Z This warning is for project developers.  Use -Wno-dev to suppress it.
2021-01-31T19:13:42.5287461Z 
2021-01-31T19:13:42.5295820Z CMake Warning (dev) in CMakeLists.txt:
2021-01-31T19:13:42.5296431Z   Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
2021-01-31T19:13:42.5297383Z   empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
2021-01-31T19:13:42.5298049Z   for policy details.  Use the cmake_policy command to set the policy and
2021-01-31T19:13:42.5298589Z   suppress this warning.
2021-01-31T19:13:42.5298835Z 
2021-01-31T19:13:42.5299439Z   CUDA_ARCHITECTURES is empty for target "histo_16_64_256-fulldata_sp".
2021-01-31T19:13:42.5300464Z This warning is for project developers.  Use -Wno-dev to suppress it.
2021-01-31T19:13:42.5300837Z 
2021-01-31T19:13:42.5309280Z CMake Warning (dev) in CMakeLists.txt:
2021-01-31T19:13:42.5309874Z   Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
2021-01-31T19:13:42.5310874Z   empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
2021-01-31T19:13:42.5311540Z   for policy details.  Use the cmake_policy command to set the policy and
2021-01-31T19:13:42.5312052Z   suppress this warning.
2021-01-31T19:13:42.5312283Z 
2021-01-31T19:13:42.5313410Z   CUDA_ARCHITECTURES is empty for target "histo_16_64_256-fulldata_sp_const".
2021-01-31T19:13:42.5314284Z This warning is for project developers.  Use -Wno-dev to suppress it.
2021-01-31T19:13:42.5314670Z 
2021-01-31T19:13:42.5323321Z CMake Warning (dev) in CMakeLists.txt:
2021-01-31T19:13:42.5323944Z   Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
2021-01-31T19:13:42.5324921Z   empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
2021-01-31T19:13:42.5325606Z   for policy details.  Use the cmake_policy command to set the policy and
2021-01-31T19:13:42.5326102Z   suppress this warning.
2021-01-31T19:13:42.5326353Z 
2021-01-31T19:13:42.5326754Z   CUDA_ARCHITECTURES is empty for target "_lightgbm".
2021-01-31T19:13:42.5327542Z This warning is for project developers.  Use -Wno-dev to suppress it.
2021-01-31T19:13:42.5327927Z 
2021-01-31T19:13:42.5358668Z CMake Warning (dev) in CMakeLists.txt:
2021-01-31T19:13:42.5359284Z   Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
2021-01-31T19:13:42.5360269Z   empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
2021-01-31T19:13:42.5360948Z   for policy details.  Use the cmake_policy command to set the policy and
2021-01-31T19:13:42.5361442Z   suppress this warning.
2021-01-31T19:13:42.5361688Z 
2021-01-31T19:13:42.5362075Z   CUDA_ARCHITECTURES is empty for target "_lightgbm".
2021-01-31T19:13:42.5362889Z This warning is for project developers.  Use -Wno-dev to suppress it.
2021-01-31T19:13:42.5363258Z 
2021-01-31T19:13:42.5372146Z CMake Warning (dev) in CMakeLists.txt:
2021-01-31T19:13:42.5372770Z   Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
2021-01-31T19:13:42.5373754Z   empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
2021-01-31T19:13:42.5374418Z   for policy details.  Use the cmake_policy command to set the policy and
2021-01-31T19:13:42.5374931Z   suppress this warning.
2021-01-31T19:13:42.5375175Z 
2021-01-31T19:13:42.5375559Z   CUDA_ARCHITECTURES is empty for target "lightgbm".
2021-01-31T19:13:42.5376338Z This warning is for project developers.  Use -Wno-dev to suppress it.
2021-01-31T19:13:42.5376726Z 
2021-01-31T19:13:42.5409236Z CMake Warning (dev) in CMakeLists.txt:
2021-01-31T19:13:42.5409858Z   Policy CMP0104 is not set: CMAKE_CUDA_ARCHITECTURES now detected for NVCC,
2021-01-31T19:13:42.5410998Z   empty CUDA_ARCHITECTURES not allowed.  Run "cmake --help-policy CMP0104"
2021-01-31T19:13:42.5411694Z   for policy details.  Use the cmake_policy command to set the policy and
2021-01-31T19:13:42.5412192Z   suppress this warning.
2021-01-31T19:13:42.5412440Z 
2021-01-31T19:13:42.5412843Z   CUDA_ARCHITECTURES is empty for target "lightgbm".
2021-01-31T19:13:42.5413678Z This warning is for project developers.  Use -Wno-dev to suppress it.
2021-01-31T19:13:42.5414071Z 
2021-01-31T19:13:42.5437100Z -- Generating done
2021-01-31T19:13:42.5450425Z -- Build files have been written to: /LightGBM/build
2021-01-31T19:13:42.5709855Z Scanning dependencies of target histo_16_64_256_sp_const
2021-01-31T19:13:42.5719864Z Scanning dependencies of target histo_16_64_256-fulldata_sp
2021-01-31T19:13:42.5759168Z Scanning dependencies of target histo_16_64_256-fulldata_sp_const
2021-01-31T19:13:42.5805981Z [  2%] Building CUDA object CMakeFiles/histo_16_64_256_sp_const.dir/src/treelearner/kernels/histogram_16_64_256.cu.o
2021-01-31T19:13:42.5806914Z Scanning dependencies of target histo_16_64_256_sp
2021-01-31T19:13:42.5840832Z [  5%] Building CUDA object CMakeFiles/histo_16_64_256-fulldata_sp.dir/src/treelearner/kernels/histogram_16_64_256.cu.o
2021-01-31T19:13:42.5850228Z [  7%] Building CUDA object CMakeFiles/histo_16_64_256-fulldata_sp_const.dir/src/treelearner/kernels/histogram_16_64_256.cu.o
2021-01-31T19:13:42.5918232Z [ 10%] Building CUDA object CMakeFiles/histo_16_64_256_sp.dir/src/treelearner/kernels/histogram_16_64_256.cu.o
2021-01-31T19:13:47.0133756Z [ 10%] Built target histo_16_64_256_sp_const
2021-01-31T19:13:47.0299592Z [ 10%] Built target histo_16_64_256-fulldata_sp_const
2021-01-31T19:13:47.0941716Z [ 10%] Built target histo_16_64_256-fulldata_sp
2021-01-31T19:13:47.0942276Z [ 10%] Built target histo_16_64_256_sp
2021-01-31T19:13:47.1748182Z Scanning dependencies of target _lightgbm
2021-01-31T19:13:47.1857452Z [ 12%] Building CXX object CMakeFiles/_lightgbm.dir/src/boosting/gbdt_model_text.cpp.o
2021-01-31T19:13:47.1863920Z [ 15%] Building CXX object CMakeFiles/_lightgbm.dir/src/boosting/gbdt_prediction.cpp.o
2021-01-31T19:13:47.1867092Z [ 17%] Building CXX object CMakeFiles/_lightgbm.dir/src/boosting/gbdt.cpp.o
2021-01-31T19:13:47.1871396Z [ 20%] Building CXX object CMakeFiles/_lightgbm.dir/src/boosting/boosting.cpp.o
2021-01-31T19:13:48.9940187Z [ 22%] Building CXX object CMakeFiles/_lightgbm.dir/src/boosting/prediction_early_stop.cpp.o
2021-01-31T19:13:49.5084405Z [ 25%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/bin.cpp.o
2021-01-31T19:13:50.4922037Z [ 27%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/config.cpp.o
2021-01-31T19:13:51.1659990Z [ 30%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/config_auto.cpp.o
2021-01-31T19:13:51.5000441Z [ 32%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/dataset.cpp.o
2021-01-31T19:13:53.3006611Z [ 35%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/dataset_loader.cpp.o
2021-01-31T19:13:54.5406018Z [ 37%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/file_io.cpp.o
2021-01-31T19:13:55.0465282Z [ 40%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/json11.cpp.o
2021-01-31T19:13:56.7408427Z [ 42%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/metadata.cpp.o
2021-01-31T19:13:57.1226727Z [ 45%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/parser.cpp.o
2021-01-31T19:13:58.2957067Z [ 47%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/train_share_states.cpp.o
2021-01-31T19:13:59.1243210Z [ 50%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/tree.cpp.o
2021-01-31T19:13:59.1820761Z [ 52%] Building CXX object CMakeFiles/_lightgbm.dir/src/metric/dcg_calculator.cpp.o
2021-01-31T19:14:00.1318363Z [ 55%] Building CXX object CMakeFiles/_lightgbm.dir/src/metric/metric.cpp.o
2021-01-31T19:14:01.2249027Z [ 57%] Building CXX object CMakeFiles/_lightgbm.dir/src/network/ifaddrs_patch.cpp.o
2021-01-31T19:14:01.2534821Z [ 60%] Building CXX object CMakeFiles/_lightgbm.dir/src/network/linker_topo.cpp.o
2021-01-31T19:14:01.5143247Z [ 62%] Building CXX object CMakeFiles/_lightgbm.dir/src/network/linkers_mpi.cpp.o
2021-01-31T19:14:01.5424486Z [ 65%] Building CXX object CMakeFiles/_lightgbm.dir/src/network/linkers_socket.cpp.o
2021-01-31T19:14:02.5739741Z [ 67%] Building CXX object CMakeFiles/_lightgbm.dir/src/network/network.cpp.o
2021-01-31T19:14:03.8514838Z [ 70%] Building CXX object CMakeFiles/_lightgbm.dir/src/objective/objective_function.cpp.o
2021-01-31T19:14:04.3885395Z [ 72%] Building CUDA object CMakeFiles/_lightgbm.dir/src/treelearner/cuda_kernel_launcher.cu.o
2021-01-31T19:14:05.3860674Z [ 75%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/cuda_tree_learner.cpp.o
2021-01-31T19:14:06.1817172Z [ 77%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/data_parallel_tree_learner.cpp.o
2021-01-31T19:14:06.5877176Z In file included from /LightGBM/src/treelearner/cuda_tree_learner.cpp:6:
2021-01-31T19:14:06.5879095Z /LightGBM/src/treelearner/cuda_tree_learner.h:48:11: warning: 'Train' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
2021-01-31T19:14:06.5880522Z     Tree* Train(const score_t* gradients, const score_t *hessians, bool is_first_tree);
2021-01-31T19:14:06.5881055Z           ^
2021-01-31T19:14:06.5881791Z /LightGBM/src/treelearner/serial_tree_learner.h:78:9: note: overridden virtual function is here
2021-01-31T19:14:06.5891662Z   Tree* Train(const score_t* gradients, const score_t *hessians, bool is_first_tree) override;
2021-01-31T19:14:06.5892195Z         ^
2021-01-31T19:14:07.3526198Z In file included from /LightGBM/src/treelearner/data_parallel_tree_learner.cpp:9:
2021-01-31T19:14:07.3527007Z In file included from /LightGBM/src/treelearner/parallel_tree_learner.h:15:
2021-01-31T19:14:07.3528754Z /LightGBM/src/treelearner/cuda_tree_learner.h:48:11: warning: 'Train' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
2021-01-31T19:14:07.3529842Z     Tree* Train(const score_t* gradients, const score_t *hessians, bool is_first_tree);
2021-01-31T19:14:07.3530345Z           ^
2021-01-31T19:14:07.3530907Z /LightGBM/src/treelearner/serial_tree_learner.h:78:9: note: overridden virtual function is here
2021-01-31T19:14:07.3531696Z   Tree* Train(const score_t* gradients, const score_t *hessians, bool is_first_tree) override;
2021-01-31T19:14:07.3532200Z         ^
2021-01-31T19:14:08.4000239Z In file included from /LightGBM/src/treelearner/cuda_tree_learner.cpp:6:
2021-01-31T19:14:08.4001894Z /LightGBM/src/treelearner/cuda_tree_learner.h:202:12: warning: private field 'ptr_pinned_gradients_' is not used [-Wunused-private-field]
2021-01-31T19:14:08.4002816Z     void * ptr_pinned_gradients_ = nullptr;
2021-01-31T19:14:08.4003175Z            ^
2021-01-31T19:14:08.4004140Z /LightGBM/src/treelearner/cuda_tree_learner.h:206:12: warning: private field 'ptr_pinned_hessians_' is not used [-Wunused-private-field]
2021-01-31T19:14:08.4004936Z     void * ptr_pinned_hessians_ = nullptr;
2021-01-31T19:14:08.4005295Z            ^
2021-01-31T19:14:08.6352562Z [ 80%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/feature_parallel_tree_learner.cpp.o
2021-01-31T19:14:09.1573517Z 3 warnings generated.
2021-01-31T19:14:09.1719786Z [ 82%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/gpu_tree_learner.cpp.o
2021-01-31T19:14:09.2014813Z [ 85%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/linear_tree_learner.cpp.o
2021-01-31T19:14:09.3908144Z [ 87%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/serial_tree_learner.cpp.o
2021-01-31T19:14:09.8020995Z In file included from /LightGBM/src/treelearner/feature_parallel_tree_learner.cpp:8:
2021-01-31T19:14:09.8021803Z In file included from /LightGBM/src/treelearner/parallel_tree_learner.h:15:
2021-01-31T19:14:09.8023633Z /LightGBM/src/treelearner/cuda_tree_learner.h:48:11: warning: 'Train' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
2021-01-31T19:14:09.8024991Z     Tree* Train(const score_t* gradients, const score_t *hessians, bool is_first_tree);
2021-01-31T19:14:09.8025515Z           ^
2021-01-31T19:14:09.8026057Z /LightGBM/src/treelearner/serial_tree_learner.h:78:9: note: overridden virtual function is here
2021-01-31T19:14:09.8026991Z   Tree* Train(const score_t* gradients, const score_t *hessians, bool is_first_tree) override;
2021-01-31T19:14:09.8027482Z         ^
2021-01-31T19:14:10.5038236Z 1 warning generated.
2021-01-31T19:14:10.5178757Z [ 90%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/tree_learner.cpp.o
2021-01-31T19:14:11.6962571Z In file included from /LightGBM/src/treelearner/tree_learner.cpp:7:
2021-01-31T19:14:11.6964845Z /LightGBM/src/treelearner/cuda_tree_learner.h:48:11: warning: 'Train' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
2021-01-31T19:14:11.6966224Z     Tree* Train(const score_t* gradients, const score_t *hessians, bool is_first_tree);
2021-01-31T19:14:11.6966949Z           ^
2021-01-31T19:14:11.6967837Z /LightGBM/src/treelearner/serial_tree_learner.h:78:9: note: overridden virtual function is here
2021-01-31T19:14:11.6969017Z   Tree* Train(const score_t* gradients, const score_t *hessians, bool is_first_tree) override;
2021-01-31T19:14:11.6969513Z         ^
2021-01-31T19:14:11.9908586Z 1 warning generated.
2021-01-31T19:14:12.0045536Z [ 92%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/voting_parallel_tree_learner.cpp.o
2021-01-31T19:14:13.1779712Z In file included from /LightGBM/src/treelearner/voting_parallel_tree_learner.cpp:11:
2021-01-31T19:14:13.1780578Z In file included from /LightGBM/src/treelearner/parallel_tree_learner.h:15:
2021-01-31T19:14:13.1782322Z /LightGBM/src/treelearner/cuda_tree_learner.h:48:11: warning: 'Train' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
2021-01-31T19:14:13.1783415Z     Tree* Train(const score_t* gradients, const score_t *hessians, bool is_first_tree);
2021-01-31T19:14:13.1783881Z           ^
2021-01-31T19:14:13.1784470Z /LightGBM/src/treelearner/serial_tree_learner.h:78:9: note: overridden virtual function is here
2021-01-31T19:14:13.1785271Z   Tree* Train(const score_t* gradients, const score_t *hessians, bool is_first_tree) override;
2021-01-31T19:14:13.1785779Z         ^
2021-01-31T19:14:13.5971918Z 1 warning generated.
2021-01-31T19:14:13.6113929Z [ 95%] Building CXX object CMakeFiles/_lightgbm.dir/src/c_api.cpp.o
2021-01-31T19:14:31.4437003Z 1 warning generated.
2021-01-31T19:14:31.4598729Z [ 97%] Linking CUDA device code CMakeFiles/_lightgbm.dir/cmake_device_link.o
2021-01-31T19:14:31.7280301Z [100%] Linking CXX shared library ../lib_lightgbm.so
2021-01-31T19:14:31.9997804Z [100%] Built target _lightgbm

guolinke
guolinke approved these changes Feb 9, 2021
View reviewed changes
Copy link
Collaborator

@guolinke guolinke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@StrikerRUS StrikerRUS merged commit 846b512 into master Feb 9, 2021
@StrikerRUS StrikerRUS deleted the cuda_warnings branch February 9, 2021 12:43
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guolinke guolinke guolinke approved these changes

@btrotta btrotta Awaiting requested review from btrotta

@chivee chivee Awaiting requested review from chivee

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StrikerRUS @guolinke @jameslamb