Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dask][tests] reduce code duplication in Dask tests #3828

Merged
merged 1 commit into from
Jan 24, 2021
Merged

Conversation

StrikerRUS
Copy link
Collaborator

Ensure that local and Dask estimators share the same parameters.

Argument should be preferred to param alias (seed -> random_state) because internally both values are stored and then cpp code produces warning for ambiguous values.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thank you

@StrikerRUS StrikerRUS merged commit ac706e1 into master Jan 24, 2021
@StrikerRUS StrikerRUS deleted the dask_test2 branch January 24, 2021 01:49
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants