[refactor] SWIG - Split pointer manipulation to individual .i file #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @imatiach-msft , as you are the core maintainer of SWIG, can you review this one? I just moved the existing code to a separate file and added a brief overview. |
AlbertoEAF
force-pushed
the
refactor-swig-files
branch
from
b77abf0
to
e25cdfe
Compare
|
@guolinke can we merge this? |
AlbertoEAF
force-pushed
the
refactor-swig-files
branch
from
e25cdfe
to
670eed2
Compare
guolinke
approved these changes
Nov 24, 2020
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make SWIG interface declarations more readable,
pointer manipulation methods were split to a separate module.