Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Order Constraint Test Silently Fails on Incorrect Type #21

Open
JonathanTripp opened this issue Jun 17, 2021 · 0 comments
Open

Order Constraint Test Silently Fails on Incorrect Type #21

JonathanTripp opened this issue Jun 17, 2021 · 0 comments

Comments

@JonathanTripp
Copy link
Contributor

In BaseOrderConstraint.cs there is a catch clause to handle incorrect type conversions. The Check returns false but there is no other indication that the constraint is malformed. Reconsider this design because the types of the DICOM tags is specified in the spec, so the user should be warned that the constraint will never pass.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant