Deprecate getStackContext #16877
Merged
Deprecate getStackContext #16877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
Abe27342
approved these changes
Aug 16, 2023
jatgarg
pushed a commit
to jatgarg/FluidFramework-1
that referenced
this pull request
Aug 18, 2023
Mark the getStackContext APIs and ReferenceType.NestBegin/NestEnd (only used for getStackContext) as deprecated. No one uses them and it causes bookkeeping in hierBlock (rangeStacks). It's also not really tested. The later removal is not yet scheduled (the functionality needs to be removed from a couple of our examples) but marking them deprecated should discourage new usages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the getStackContext APIs and ReferenceType.NestBegin/NestEnd (only used for getStackContext) as deprecated. No one uses them and it causes bookkeeping in hierBlock (rangeStacks). It's also not really tested.
The later removal is not yet scheduled (the functionality needs to be removed from a couple of our examples) but marking them deprecated should discourage new usages.