Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid gds build errors on ROCm #6456

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

rraminen
Copy link
Contributor

@rraminen rraminen commented Aug 28, 2024

This PR is to avoid the below error during DeepSpeed build on ROCm. The error is because of the incompatibility of GDSBuilder extension on ROCm.

    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-req-build-lv1v39xc/setup.py", line 180, in <module>
        op_compatible = builder.is_compatible()
      File "/tmp/pip-req-build-lv1v39xc/op_builder/gds.py", line 47, in is_compatible
        CUDA_LIB64 = os.path.join(CUDA_HOME, "lib64")
      File "/opt/conda/envs/py_3.9/lib/python3.9/posixpath.py", line 76, in join
        a = os.fspath(a)
    TypeError: expected str, bytes or os.PathLike object, not NoneType
    Total number of unsupported CUDA function calls: 0


    Total number of replaced kernel launches: 1
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output

cc: @jithunnair-amd

@rraminen rraminen marked this pull request as draft August 28, 2024 17:56
@loadams loadams requested a review from jomayeri August 28, 2024 18:09
op_builder/gds.py Outdated Show resolved Hide resolved
@rraminen rraminen marked this pull request as ready for review August 28, 2024 19:57
@loadams loadams enabled auto-merge August 29, 2024 15:57
@loadams loadams added this pull request to the merge queue Aug 29, 2024
Merged via the queue into microsoft:master with commit a7ffe54 Aug 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants