Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking "Sign In" on an OAuth Card opens the file explorer #2130

Closed
JeganBas opened this issue Apr 16, 2020 · 15 comments · Fixed by #2155
Closed

Clicking "Sign In" on an OAuth Card opens the file explorer #2130

JeganBas opened this issue Apr 16, 2020 · 15 comments · Fixed by #2155
Assignees
Labels
Bot Services equired for internal Azure reporting. Do not delete. Do not change color. Bug Your classic code defect customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. R10 Release 10 - August 17th, 2020

Comments

@JeganBas
Copy link

JeganBas commented Apr 16, 2020

In the recent version 4.8.1 of Emulator,
I'm running the Authentication sample Bot, in that while Signing in , the emulator is not redirecting to a browser window to generate the token, instead it is opening the explorer window.

Is there any fix or workaround for this issue.

because of this issue I'm unable to debug my project, also this issue is not there in the previous version,

@tonyanziano tonyanziano added Bug Your classic code defect customer-reported Required for internal Azure reporting. Do not delete. labels Apr 16, 2020
@dmvtech dmvtech added the Bot Services equired for internal Azure reporting. Do not delete. Do not change color. label Apr 16, 2020
@axelsrz axelsrz assigned tonyanziano and dmvtech and unassigned tonyanziano Apr 16, 2020
@axelsrz
Copy link
Member

axelsrz commented Apr 16, 2020

Hey @dmvtech could you take a look at this one? Thanks

@dmvtech
Copy link
Collaborator

dmvtech commented Apr 16, 2020

@JeganBas If not already done, can you confirm this reproduces after selecting Clear state from the File menu?

If so, can you please grab a fiddler trace. You can send to me at v-danava@microsoft.com

@dmvtech dmvtech added the customer-replied-to Required for internal reporting. Do not delete. label Apr 16, 2020
@JeganBas
Copy link
Author

Even after clearing the state it's the same results, the emulator keep opening the explorer window instead of browser while signing in. I'm unable to use fiddler here. Suggest me a different solution please

@dmvtech
Copy link
Collaborator

dmvtech commented Apr 22, 2020

I am able to reproduce. To clarify; it is opening File Explorer (explorer.exe).

@dmvtech
Copy link
Collaborator

dmvtech commented Apr 22, 2020

Looks like a regression #1397

@tonyanziano

@JeganBas
Copy link
Author

@dmvtech yes , its opening the File explorer only, what could be the fix for this ?

@tonyanziano
Copy link
Contributor

Thanks for looking into this @dmvtech .

I'll dig around a bit once I get an auth sample working. It's possible that something changed inside Web Chat and that's the cause, but that's just a hunch at the moment.

@tonyanziano tonyanziano assigned tonyanziano and unassigned dmvtech Apr 22, 2020
@tonyanziano
Copy link
Contributor

I tried to reproduce it, but I can't on my end 🤔

image

This is on v4.8.1.

@JeganBas if you downgrade to a previous version, like 4.8.0 or 4.7, do you still experience this issue? If we could narrow it down to a certain version then we can look at the delta in the past commits and see if there is anything that might have caused it.

@JeganBas
Copy link
Author

Hi @tonyanziano , I've downgarded to Emulator 4.7 and now i can able to sign In, so the problem is only in 4.8.1

@tonyanziano
Copy link
Contributor

Thanks for testing that out @JeganBas ,

We can take a look at what changed between 4.7 and 4.8.1 and see if there are any obvious commits that might have caused this behavior.

@geo-msft
Copy link

geo-msft commented May 7, 2020

hi, if you set the path to ngrok in the emulator settings, the Oauth Card will show the expected result: the prompt to login:

image

After multiple tests, I noticed the issue happens when the path is empty.

@benbrown benbrown added the R10 Release 10 - August 17th, 2020 label May 19, 2020
@tonyanziano tonyanziano changed the title Sign In is not working Clicking "Sign In" on an OAuth Card opens the file explorer May 20, 2020
@tonyanziano
Copy link
Contributor

I'm now able to reproduce this reliably.

Video for reference

This is indeed a bug in the sense that clicking the sign-in link should not open the file explorer, however, that being said, the following still remains true:

  • When reproducing this bug, as you can see in the video I posted, as soon as the sign-in card is generated, an error message is printed out in the Emulator log panel stating that the Emulator was unable to start up ngrok due to the ngrok path being wrong or blank in the app setting page. This is the correct behavior, and receiving an actual OAuth token without configuring ngrok is still impossible and will remain this way.

  • When ngrok is not configured, clicking on the sign-in card should still cause the Emulator to give the bot a token, however it will be an emulated token (not generated by the token service) prefixed with emulatedToken_ that the user can use for testing purposes

  • Once I fix this bug, the user will once again be able to get an emulated token from the Emulator when ngrok is not configured

@tonyanziano
Copy link
Contributor

This fix will be in the next nightly build (usually gets published around 11 PM PST).

@tonyanziano
Copy link
Contributor

@JeganBas @geo-msft

Please validate this issue has been fixed in the latest nightly build:

https://github.com/microsoft/botframework-emulator-nightlies/releases/tag/v4.9.0-137331

@JeganBas
Copy link
Author

@tonyanziano thanks for updating, i will validate the new build and update you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services equired for internal Azure reporting. Do not delete. Do not change color. Bug Your classic code defect customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. R10 Release 10 - August 17th, 2020
Projects
None yet
6 participants