Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simAddVehicle for Car vehicle #4203

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Conversation

rajat2004
Copy link
Contributor

@rajat2004 rajat2004 commented Dec 9, 2021

Fixes: #

About

simAddVehicle API failed with Car with the error in #4109 (comment)
This PR fixes the extra reset call, allowing it to work for Car, CV vehicles

Alos update the docs for this API

How Has This Been Tested?

Using the script added in the PR -

airsim_runtime_car.mp4

For CV mode -

>>> import airsim
>>> cl = airsim.VehicleClient()
>>> cl.confirmConnection()
Connected!
Client Ver:1 (Min Req: 1), Server Ver:1 (Min Req: 1)

>>> pose = airsim.Pose()
>>> print(cl.simAddVehicle("CV2", "ComputerVision", pose))
True

Verified that HelloSpawnedDrones was working as expected

Screenshots (if appropriate):

Docs -
Screenshot from 2021-12-12 21-19-23

@jonyMarino jonyMarino added the bug label Dec 13, 2021
@zimmy87
Copy link
Contributor

zimmy87 commented Dec 16, 2021

Tested this locally and it works for me, so I am moving ahead with merging; thanks for the contribution @rajat2004!

@zimmy87 zimmy87 merged commit 233b3cf into microsoft:master Dec 16, 2021
@rajat2004 rajat2004 deleted the runtime-car branch January 1, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants