Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Travis] Add Ubuntu 20.04, OSX XCode 11.5 jobs #2953

Merged
merged 4 commits into from
Oct 3, 2020

Conversation

rajat2004
Copy link
Contributor

No documentation changes until tested, currently Focal build fails due to a Python package trollius not working on Python 3.8, used in ROS somewhere

@saihv
Copy link
Contributor

saihv commented Oct 2, 2020

catkin-tools in Noetic should be using asyncio instead of trollius as it natively works with Python 3.

catkin/catkin_tools#574

Do you have any error logs relating to the trollius errors?

@rajat2004
Copy link
Contributor Author

Ahh yes, sorry, forgot to put a link to my Travis build, here's the currently running one - https://travis-ci.com/github/rajat2004/AirSim/builds/187740417
And the build before that - https://travis-ci.com/github/rajat2004/AirSim/builds/180634888
Not sure why Travis isn't appearing here though

I didn't dig into this at the time since got busy with other things, will try to look at them more now

@rajat2004
Copy link
Contributor Author

Yeah, so the problem is still there, seems like there hasn't been a new release of catkin_tools with the trollius fix, should it be installed from the git repo instead?

@saihv
Copy link
Contributor

saihv commented Oct 2, 2020

The latest travis build is still pulling catkin_tools 0.6.1, the async fix is only present in 0.7.0+.
image

Could you try this?
sudo apt install python3-osrf-pycommon python3-catkin-tools

@rajat2004
Copy link
Contributor Author

rajat2004 commented Oct 3, 2020

@saihv I thought I had tried out installing from apt earlier, but didn't work. Just tried it out again - https://travis-ci.com/github/rajat2004/AirSim/builds/187934390
Works with 20.04, but breaks 18.04, 16.04. I'll try a bit again to get things working by shifting apt<->pip in places, but I think the easiest way might be to just run the appropriate command for 20.04 separately

As for the pip install, 0.6.1 is the latest release - https://pypi.org/project/catkin-tools/
From this issue - catkin/catkin_tools#594, which is still open, release 0.7.0 has yet to happen

I've added an if-block to install catkin_tools from source on Ubuntu 20.04, Travis build is working - https://travis-ci.com/github/rajat2004/AirSim/builds/187936045
Does this way seem okay, or should something else be done?

@saihv
Copy link
Contributor

saihv commented Oct 3, 2020

This looks good. I guess we'll keep an eye out and unify the scripts once the fixed catkin_tools is released. Thanks for looking into this!

@saihv saihv merged commit 05a9625 into microsoft:master Oct 3, 2020
@rajat2004 rajat2004 deleted the travis-focal-osx branch October 3, 2020 07:41
@rajat2004
Copy link
Contributor Author

Great, thanks for merging!
Documentation can be updated after some testing has been done on Ubuntu 20.04
Could you perhaps have a look at why Travis isn't appearing in the CI checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants