Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements to world API #2898

Merged
merged 8 commits into from
Sep 2, 2020

Conversation

saihv
Copy link
Contributor

@saihv saihv commented Jul 31, 2020

Consolidating some bug fixes and improvements to the world API. Work in progress.

  • Handle the corner case when UE deletes an actor visually and from the actor list but reference still exists in memory, causing fatal errors when another object of the same name is spawned.
  • Queue up garbage collection when an actor is destroyed.
  • Use a TMap for name<->asset mapping, instead of iterating through all assets in the database in GetMeshfromRegistry at every spawn.
  • Use a TMap for name<->actor mapping, instead of iterating through all actors in scene at every object API call.

@madratman madratman merged commit 4c1bedc into microsoft:master Sep 2, 2020
@rajat2004
Copy link
Contributor

rajat2004 commented Sep 3, 2020

This broke AirSim on UE 4.24 -

/home/rajat/AirSim/Unreal/Environments/Blocks/Plugins/AirSim/Source/WorldSimApi.cpp:116:40: error: no member named 'NameMode' in 'FActorSpawnParameters'
                new_actor_spawn_params.NameMode = FActorSpawnParameters::ESpawnActorNameMode::Required_ReturnNull;
                ~~~~~~~~~~~~~~~~~~~~~~ ^
/home/rajat/AirSim/Unreal/Environments/Blocks/Plugins/AirSim/Source/WorldSimApi.cpp:116:74: error: no member named 'ESpawnActorNameMode' in 'FActorSpawnParameters'
                new_actor_spawn_params.NameMode = FActorSpawnParameters::ESpawnActorNameMode::Required_ReturnNull;
                                                  ~~~~~~~~~~~~~~~~~~~~~~~^
2 errors generated.
LogInit: Warning: Still incompatible or missing module: Blocks

Are we moving on to 4.25 entirely? In that case, docs need to be updated
Or should this be fixed somehow

@saihv
Copy link
Contributor Author

saihv commented Sep 4, 2020

@rajat2004 I reverted that change in #3000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants