documentation: "keepEscaping" is missing

[vemoo]

I'm not sure if it's a braces or micromatch issue, but

braces("C:/Program Files \\(x86\\)")

returns

[ "C:/Program Files (x86)" ]

losing the escape characters, making

micromatch.parse("C:/Program Files \\(x86\\)")

return the tokens

[
	{
		"type": "bos",
		"value": "",
		"output": ""
	},
	{
		"type": "text",
		"value": "C:"
	},
	{
		"type": "slash",
		"value": "/",
		"output": "\\/"
	},
	{
		"type": "text",
		"value": "Program Files "
	},
	{
		"type": "paren",
		"value": "("
	},
	{
		"type": "text",
		"value": "x86"
	},
	{
		"type": "paren",
		"value": ")",
		"output": ")"
	}
]

vs what I expected and what

picomatch.parse("C:/Program Files \\(x86\\)")

returns

[
	{
		"type": "bos",
		"value": "",
		"output": ""
	},
	{
		"type": "text",
		"value": "C:"
	},
	{
		"type": "slash",
		"value": "/",
		"output": "\\/"
	},
	{
		"type": "text",
		"value": "Program Files \\(x86\\)"
	}
]

Here's some sample code: https://repl.it/repls/SharpStrangeChemistry

[vemoo]

I've realized theres options.unescape but it doesn't seem to do anything in this case.

[jonschlinkert]

That's not right, this is a bug, and it's inconsistent with how picomatch works. It should allow you to retain escaping. Thank you for reporting it.

[jonschlinkert]

ah, wait. The option is keepEscaping. I forgot that I used a different option name to allow you to escape one or the other, or both. If both picomatch and braces had the same option name (unescape) for this specifically, you wouldn't be able to control escaping.

Try this:

console.log(braces("C:/Program Files \\(x86\\)", { keepEscaping: true }));

[vemoo]

Yes, that works. Then the documentation should be updated and it should be added to the documentation of micromatch.

[jonschlinkert]

Then the documentation should be updated and it should be added to the documentation of micromatch.

Agreed! Thanks for reporting this. Want to do a PR?