Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid uint64_t operation when handling context (backport #16) #17

Merged
merged 2 commits into from
May 9, 2022

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 9, 2022

This is an automatic backport of pull request #16 done by Mergify.
Cherry-pick of 32aa288 has failed:

On branch mergify/bp/foxy/pr-16
Your branch is up to date with 'origin/foxy'.

You are currently cherry-picking commit 32aa288.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rcl/src/rcl/context.c
	modified:   rcl/src/rcl/init.c

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rcl/include/rcl/context.h

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

* Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

* Clean PR

* Clean id rollover check

* Fix rollover

Co-authored-by: acuadros95 <acuadros1995@gmail.com>
(cherry picked from commit 32aa288)

# Conflicts:
#	rcl/include/rcl/context.h
Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
@pablogs9 pablogs9 closed this May 9, 2022
@pablogs9 pablogs9 deleted the mergify/bp/foxy/pr-16 branch May 9, 2022 07:29
@pablogs9 pablogs9 restored the mergify/bp/foxy/pr-16 branch May 9, 2022 07:29
@pablogs9 pablogs9 reopened this May 9, 2022
@pablogs9 pablogs9 merged commit ab28555 into foxy May 9, 2022
@mergify mergify bot deleted the mergify/bp/foxy/pr-16 branch May 9, 2022 07:29
pablogs9 added a commit that referenced this pull request May 18, 2022
* Avoid uint64_t operation when handling context (#16)

* Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

* Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

* Clean PR

* Clean id rollover check

* Fix rollover

Co-authored-by: acuadros95 <acuadros1995@gmail.com>
(cherry picked from commit 32aa288)

# Conflicts:
#	rcl/include/rcl/context.h

* Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
pablogs9 added a commit that referenced this pull request Jul 26, 2022
* Avoid uint64_t operation when handling context (#16)

* Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

* Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

* Clean PR

* Clean id rollover check

* Fix rollover

Co-authored-by: acuadros95 <acuadros1995@gmail.com>
(cherry picked from commit 32aa288)

# Conflicts:
#	rcl/include/rcl/context.h

* Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant